Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail build if an unsupported or unknown operating system is specified in TargetFramework #11232

Closed
dsplaisted opened this issue Apr 10, 2020 · 1 comment · Fixed by #12632
Closed
Assignees
Milestone

Comments

@dsplaisted
Copy link
Member

dsplaisted commented Apr 10, 2020

If the TargetFramework is something like net5.0-mycustomos, we should fail the build with an error that we don't know what mycustomos is.

Suggested logic:

  • Platform-specific targets (usually in workloads) will set TargetPlatformSupported to true if the TargetPlatformIdentifier is set to something they recognize and support
  • Base SDK will generate an error message if TargetPlatformIdentifier is non-empty and TargetPlatformSupported is not true

If a workload supports a given target platform, it should be responsible for generating error messages if the target platform version specified is one it doesn't support (or doesn't support in combination with the target framework version).

@Nirmal4G
Copy link
Contributor

We should be allowing the optional workloads to understand the custom Frameworks and Platforms. That gives us the opportunity to experiment without modifying NuGet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants