Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer WinExe output type as appropriate #11398

Closed
dsplaisted opened this issue Apr 23, 2020 · 2 comments · Fixed by #12152
Closed

Infer WinExe output type as appropriate #11398

dsplaisted opened this issue Apr 23, 2020 · 2 comments · Fixed by #12152
Assignees
Milestone

Comments

@dsplaisted
Copy link
Member

If a project file specifies an OutputType of Exe, we should automatically change it to WinExe if any of the following are true:

  • TargetPlatformIdentifier is windows (which will be the case if the TargetFramework is net5.0-windows
  • UseWindowsForms or UseWPF is true (this will cover projects that target .NET Core 3.x and thus don't have the TargetPlatformIdentifier set to Windows
@dsplaisted dsplaisted added this to the 5.0.1xx milestone Apr 23, 2020
@Nirmal4G
Copy link
Contributor

What If I want the console subsystem with the above cases? will there be an opt-out?

@wjk
Copy link

wjk commented Apr 27, 2020

I am writing an otherwise-100% console-based app that shows WPF-based UI in one certain circumstance. Having WPF imply WinExe would break my project's intended use-case. If I can workaround this by moving all the WPF stuff into a DLL, that's fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants