Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefineConstant is still NETCOREAPP5_0 for Net5.0 ? #11544

Closed
tebeco opened this issue May 2, 2020 · 2 comments · Fixed by #11635
Closed

DefineConstant is still NETCOREAPP5_0 for Net5.0 ? #11544

tebeco opened this issue May 2, 2020 · 2 comments · Fixed by #11635
Assignees
@sfoslund
Milestone
5.0.1xx

Comments

@tebeco
Copy link
Contributor

tebeco commented May 2, 2020

Hello,

After installing dotnet-sdk 5.0.0-preview3, changed TargetFramework from netcoreapp5.0 to net5.0, i also tried to change macro relying on existing DefineConstant from

#if NETCOREAPP5_0
#endif

to

#if NET5_0
#endif

It seems that it's still NETCOREAPP5_0 and not NET5_0
Is this intended to still use NETCOREAPP5_0 while the TargetFramework just moved out ?
@danmoseley danmoseley transferred this issue from dotnet/runtime May 2, 2020
@marcpopMSFT marcpopMSFT added the untriaged Request triage from a team member label May 6, 2020
@tebeco
Copy link
Contributor Author

tebeco commented May 7, 2020

thx @danmosemsft ;)
Sounds a bit more logic to be here ... now you migrated the issue :D
sorry about that

@sfoslund sfoslund added this to the 5.0.1xx milestone May 8, 2020
@sfoslund sfoslund removed the untriaged Request triage from a team member label May 8, 2020
@sfoslund sfoslund assigned sfoslund and unassigned sfoslund May 8, 2020
@sfoslund sfoslund mentioned this issue May 21, 2020
Merged
@tebeco
Copy link
Contributor Author

tebeco commented Jun 8, 2020

thx for the update ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfoslund sfoslund

Labels
None yet
Projects
None yet
Milestone
5.0.1xx
Development

Successfully merging a pull request may close this issue.

Adding target platform preprocessor symbols sfoslund/sdk
3 participants
@tebeco @marcpopMSFT @sfoslund