Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port PackageValidation flaky build failure fixes to 6.0 #22353

Closed
dagood opened this issue Oct 26, 2021 · 5 comments
Closed

Port PackageValidation flaky build failure fixes to 6.0 #22353

dagood opened this issue Oct 26, 2021 · 5 comments
Assignees
@joperezr
Labels
Area-ApiCompat
Milestone
6.0.3xx

Comments

@dagood
Copy link
Member

dagood commented Oct 26, 2021

This would help source-build reliability in particular (dotnet/source-build#2501) and allow removing this workaround:
@dagood dagood transferred this issue from dotnet/runtime Oct 27, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-ApiCompat untriaged Request triage from a team member labels Oct 27, 2021
@dagood dagood mentioned this issue Oct 27, 2021
Open
@safern safern removed the untriaged Request triage from a team member label Oct 27, 2021
@safern safern added this to the 6.0.1xx milestone Oct 27, 2021
@lbussell lbussell mentioned this issue Jan 11, 2022
Merged
@ericstj ericstj modified the milestones: 6.0.1xx, 6.0.2xx Jan 26, 2022
@ericstj
Copy link
Member

ericstj commented Jan 26, 2022

@safern @dagood can this be closed, or have these not yet been ported to 6.0? Adjusting to 6.0.2xx

@dagood
Copy link
Member Author

dagood commented Jan 26, 2022

Seems like it can be closed. @lbussell @MichaelSimons correct me if I'm wrong.

@dagood dagood closed this as completed Jan 26, 2022
@ericstj
Copy link
Member

ericstj commented Jan 26, 2022

FWIW I don't see @safern's fixes in 6.0 codebase.

@dagood
Copy link
Member Author

dagood commented Jan 26, 2022

Ah, yep, I must have misread some PRs.

@dagood dagood reopened this Jan 26, 2022
@safern safern self-assigned this Jan 26, 2022
@marcpopMSFT marcpopMSFT modified the milestones: 6.0.2xx, 6.0.3xx Feb 2, 2022
@ericstj ericstj assigned joperezr and unassigned safern Mar 10, 2022
@ericstj ericstj mentioned this issue Mar 10, 2022
Merged
This was referenced Mar 11, 2022
Merged
Merged
@joperezr
Copy link
Member

This was fixed by dotnet/runtime#66635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joperezr joperezr

Labels
Area-ApiCompat
Projects
None yet
Milestone
6.0.3xx
Development

No branches or pull requests
5 participants
@ericstj @marcpopMSFT @dagood @joperezr @safern