Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a solution alias for the existing sln command #40817

Closed
baronfel opened this issue May 10, 2024 · 9 comments
Closed

Create a solution alias for the existing sln command #40817

baronfel opened this issue May 10, 2024 · 9 comments
Labels
Area-CLI cli-ux Issues and PRs that deal with the UX of the CLI (exit codes, log output, verbs/options, and so on) good first issue Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined. help wanted Issues that we would accept external contributions on. Also known as up-for-grabs. new-hire-issue untriaged Request triage from a team member
Milestone

Comments

@baronfel
Copy link
Member

Is your feature request related to a problem? Please describe.

We should add a solution alias to the existing sln command. The current implementation of the sln command interacts with .sln files, but the new .slnx file format logically supports many of the same commands. Some quick surveys suggest that most users want the current sln command to interact with .slnx files, but the sln name could present some confusion. Adding a solution command

  • uses the name of the logical concept instead of tying the command to a particular file format
  • can be done in a lossless and back-compatible way
  • opens up design space for a sibling dotnet project command
  • can be tab-completed to mitigate the additional typing
@baronfel baronfel added Area-CLI cli-ux Issues and PRs that deal with the UX of the CLI (exit codes, log output, verbs/options, and so on) labels May 10, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label May 10, 2024
@baronfel baronfel added help wanted Issues that we would accept external contributions on. Also known as up-for-grabs. good first issue Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined. new-hire-issue untriaged Request triage from a team member and removed untriaged Request triage from a team member labels May 10, 2024
@kunalshokeen051
Copy link

Hi @baronfel I am new to Open-Source Can i work on this issue.

@baronfel
Copy link
Member Author

Awesome @kunalshokeen051 - I want to check with the rest of the team to make sure we want to do this, but once we chat about it and agree I'd love to accept a PR from you!

@baronfel
Copy link
Member Author

@kunalshokeen051 Ok, I've taken this to the team and we're all on board with the change. If you'd like to submit a PR we'd be happy to review and help get it merged.

@marcpopMSFT marcpopMSFT added this to the Backlog milestone May 28, 2024
@Nirmal4G
Copy link
Contributor

Why not the other way around?

Instead of just adding a solution alias to the sln command, can we rename the sln to solution command and make the command sln as a short-hand alias?

@baronfel
Copy link
Member Author

That'd be fine - there's no huge functional difference.

@Nirmal4G
Copy link
Contributor

Nirmal4G commented Jun 21, 2024

@baronfel Okay then, seems simple enough! If @kunalshokeen051 still wants to do it, please confirm, otherwise I can take it up.

@nagilson
Copy link
Member

nagilson commented Oct 1, 2024

@marcpopMSFT Assigning this to @edvilme since the open source contributor hasn't had time to get to this one.
JK there's a PR now.

@mariuszbyahoo
Copy link

Hi, due to this commit can we close this issue?

@nagilson
Copy link
Member

We can! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CLI cli-ux Issues and PRs that deal with the UX of the CLI (exit codes, log output, verbs/options, and so on) good first issue Issues that would be a good fit for someone new to the repository. Narrow in scope, well-defined. help wanted Issues that we would accept external contributions on. Also known as up-for-grabs. new-hire-issue untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

7 participants