Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prepack/postpack events to scripts #4410

Closed
analogrelay opened this issue Nov 18, 2015 · 3 comments
Closed

Add prepack/postpack events to scripts #4410

analogrelay opened this issue Nov 18, 2015 · 3 comments
Assignees

Comments

@analogrelay
Copy link
Contributor

After #4407, we have script execution in dotnet. We should add the prepack and postpack events which run before and after the dotnet pack command. Since dotnet pack executes dotnet compile, the flow looks like this:

  1. prepack
  2. dotnet-compile
    1. precompile
    2. dotnet-compile-csc
    3. postcompile
  3. Prepare outputs for packaging
  4. Create nupkg
  5. postpack

/cc @davidfowl

@analogrelay analogrelay self-assigned this Nov 18, 2015
@TheRealPiotrP
Copy link
Contributor

I think we should generalize this, per @davidfowl's suggestion.

@Sridhar-MS

@analogrelay
Copy link
Contributor Author

I mostly agree, just want to keep this here temporarily to remember it until we finalize that plan. I'll close it out once we have a clean plan there

@TheRealPiotrP
Copy link
Contributor

This is a duplicate of dotnet/cli#244

wli3 referenced this issue in wli3/cli Jul 14, 2017
Remove invalid semicolon from template VB code
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants