Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceBuiltArtifacts tarball should include portable versions of coreclr-tools #1493

Closed
dseefeld opened this issue Feb 20, 2020 · 1 comment · Fixed by #1494
Closed

SourceBuiltArtifacts tarball should include portable versions of coreclr-tools #1493

dseefeld opened this issue Feb 20, 2020 · 1 comment · Fixed by #1494
Assignees
Labels
area-infra Source-build infrastructure and reporting

Comments

@dseefeld
Copy link
Contributor

To better support all distros, SourceBuiltArtifacts should include the portable version of coreclr-tools.

@dseefeld dseefeld added the area-infra Source-build infrastructure and reporting label Feb 20, 2020
@dseefeld dseefeld self-assigned this Feb 20, 2020
@dagood
Copy link
Member

dagood commented Feb 20, 2020

(I was writing this too, posting extra info. 🙂)

Currently, we use the system libunwind for CoreCLR nonportable, and always bundle libunwind for CoreCLR portable. This is good for distros where libunwind is available, for various reasons. (dotnet/coreclr#17164.) When it isn't available, the /p:UseSystemLibraries=false MSBuild arg enables bundling everywhere.

The problem: we put the non-portable CoreCLR native tools in the previously-source-built tarball. This means that by running a tarball production build on a distro that provides libunwind (RHEL 7), the output previously-source-built tarball isn't compatible with distros that don't provide libunwind (RHEL 8).

To make this scenario easier, we should include the portable build instead. We do, generally speaking, want the tarball to be as cross-distro-compatible as reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infra Source-build infrastructure and reporting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants