Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text-only packages built by SBRP have extra files in them (intermediate output, csproj) #1906

Closed
dagood opened this issue Nov 20, 2020 · 3 comments · Fixed by dotnet/source-build-reference-packages#360
Closed

Text-only packages built by SBRP have extra files in them (intermediate output, csproj) #1906

dagood opened this issue Nov 20, 2020 · 3 comments · Fixed by dotnet/source-build-reference-packages#360
Assignees
@MichaelSimons
Labels
area-infra Source-build infrastructure and reporting

Comments

@dagood
Copy link
Member

dagood commented Nov 20, 2020

E.g. MicroBuild.Core 0.3.0 contains:

MicroBuild.Core.csproj
obj/project.assets.json
obj/MicroBuild.Core.csproj.nuget.dgspec.json
microbuild.core/0.3.0/Debug/netstandard1.3/MicroBuild.Core.assets.cache
...

These probably don't affect usage and I don't think we need to fix this for 5.0.0, but wanted to track the difference.
@dagood dagood added the area-infra Source-build infrastructure and reporting label Nov 20, 2020
@dagood dagood mentioned this issue Oct 23, 2021
Open
@dagood
Copy link
Member Author

dagood commented Oct 27, 2021

Also encountered in 6.0.100: dagood#9 (comment)

@MichaelSimons MichaelSimons moved this to 6.0 BackLog in .NET Source Build Feb 1, 2022
@MichaelSimons MichaelSimons moved this from 6.0 BackLog to WIP in .NET Source Build Mar 15, 2022
@MichaelSimons MichaelSimons self-assigned this Mar 15, 2022
@MichaelSimons MichaelSimons mentioned this issue Mar 15, 2022
Merged
Repository owner moved this from WIP to Done in .NET Source Build Mar 16, 2022
@MichaelSimons
Copy link
Member

Re-opening until change flows into 6.0.

@MichaelSimons MichaelSimons reopened this Mar 17, 2022
@MichaelSimons MichaelSimons moved this from Done to WIP in .NET Source Build Mar 17, 2022
@MichaelSimons
Copy link
Member

Flowed in with dotnet/installer#13565.

Repository owner moved this from WIP to Done in .NET Source Build Apr 7, 2022
@MichaelSimons MichaelSimons mentioned this issue Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelSimons MichaelSimons

Labels
area-infra Source-build infrastructure and reporting
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove source csproj from text-only packages MichaelSimons/source-build-reference-packages
3 participants
@dseefeld @MichaelSimons @dagood