Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate F# integration into the .NET SDK: figure out what would make it more source-build and smoke-test compatible #2581

Closed
dagood opened this issue Oct 26, 2021 · 3 comments
Labels
area-testing Improvements in CI and testing

Comments

@dagood
Copy link
Member

dagood commented Oct 26, 2021

The F# integration into the SDK is not like other components. As of writing, in the stabilized dotnet/installer 6.0.1xx branch, dotnet run on an F# project fails for both the Microsoft build and source-build, because it can't find a 6.0.1 FSharp.Core package. The package doesn't seem to exist anywhere. This can be worked around with some extra args to use a preview package instead:

$ dotnet restore /p:_NETCoreSdkIsPreview=true
$ dotnet run --no-restore /p:_NETCoreSdkIsPreview=true

This behavior makes it difficult to maintain smoke-tests, and the args cast doubt on our ability to actually test the final product that we deliver.

This needs some investigation. I think that at least, we should figure out how to be as sure as possible that we are smoke-testing the right thing. Ideally, F# can be made more source-build friendly overall. (A bonus would be to make it more friendly for Microsoft-built .NET SDK ingestion, too.)

In 6.0, there were some diffs in the FSharp part of the SDK that were concerning, and this ran into our difficulties in smoke-testing F# projects: https://github.com/dagood/source-build/pull/9/files#r736887609.

@dagood
Copy link
Member Author

dagood commented Oct 28, 2021

The Microsoft build side of this seems to be tracked here:

@crummel
Copy link
Contributor

crummel commented Sep 8, 2022

Build part of this should be fixed in dotnet/fsharp#13544, smoke-test side may actually be related to #2989 which I'm looking at now as well.

@MichaelSimons MichaelSimons moved this from 7.0 On Deck to Servicing On Deck in .NET Source Build Oct 13, 2022
@crummel
Copy link
Contributor

crummel commented Nov 8, 2022

We didn't run into this for the 7.0 release so it appears dotnet/fsharp#13544 was all it took to fix it. I am still looking into the prebuilts issue but I no longer believe it's related.

@crummel crummel closed this as completed Nov 8, 2022
Repository owner moved this from Servicing On Deck to Done in .NET Source Build Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Improvements in CI and testing
Projects
Archived in project
Development

No branches or pull requests

3 participants