Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update diagnostics version #2970

Closed
MichaelSimons opened this issue Aug 9, 2022 · 2 comments · Fixed by microsoft/vstest#3976
Closed

Update diagnostics version #2970

MichaelSimons opened this issue Aug 9, 2022 · 2 comments · Fixed by microsoft/vstest#3976
Assignees
@NikolaMilosavljevic
Labels
area-patch-removal Removing patches for contributing repos from source-build

Comments

@MichaelSimons
Copy link
Member

MichaelSimons commented Aug 9, 2022 •
edited by NikolaMilosavljevic
Loading

The diagnostics version we are building w/source-build (5.0.0-preview.21506.1) is older and should be upgraded in order to remove this patch was backported but has never flowed in.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons MichaelSimons moved this to 7.0 RC2 in .NET Source Build Aug 9, 2022
@MichaelSimons MichaelSimons added area-patch-removal Removing patches for contributing repos from source-build and removed untriaged labels Aug 11, 2022
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Aug 26, 2022
Merged
@MichaelSimons MichaelSimons moved this from 7.0 RC2 to WIP in .NET Source Build Aug 29, 2022
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Aug 29, 2022
Closed
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Sep 7, 2022
Merged
@NikolaMilosavljevic
Copy link
Member

Fixed.

Repository owner moved this from WIP to Done in .NET Source Build Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolaMilosavljevic NikolaMilosavljevic

Labels
area-patch-removal Removing patches for contributing repos from source-build
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update versions of diagnostics dependencies NikolaMilosavljevic/vstest
2 participants
@MichaelSimons @NikolaMilosavljevic