-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.0 source-build-externals depends on application-insights which contains non-open source code #3018
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
cc @mirespace |
cc @janani66 |
[Triage] @marcpopMSFT, do you have any concerns/objections with updating the SDK's app insights version to 2.21.0 to address this issue? |
I have no concerns. Does this need to be done in 6.0.1xx as well? I'm also a bit concerned that 6.0 is version 2.20 but 7.0 is version 2.19? The automated codeflow should have picked that up though it must have been lost on merge at some point. |
I got mixed up on which release contains the fix. 2.20.0 contains the needed change. I will open a PR. |
Hm, if 6.0.1xx contains App insights 2.19, does that mean it is also affected by this issue? (I haven't done a license scan on 6.0.1xx since 6.0.100). Should we update 6.0.1xx to 2.20 as well? |
@omajid 6.0.1xx actually has 2.20.0. I updated that last month and our automated codeflow got that updated in 6.0.3xx and 6.0.4xx. My comment to Michael was that somehow the update to 2.20.0 didn't flow to 7.0.1xx for some reason (maybe a merge conflict that was resolved improperly) |
Would it be possible to pick a fix for microsoft/ApplicationInsights-dotnet#2671 as well? |
Describe the Bug
https://github.com/dotnet/installer's branch
release/7.0.1xx
eventually depends on https://github.com/dotnet/source-build-externals commit 5d2a2f63bb10119240df8082dfc7646589dc1efb. This commit then uses application-insights' commit 93f745cfef8541f09862aae9bc8c04554bca38c7.That contains code that has non-open source license headers, similiar to Humanizr/sample-aspnetmvc#1
This was "fixed" in the main branch and newer releases of application-insights via microsoft/ApplicationInsights-dotnet#2486
Steps to Reproduce
Other Information
The text was updated successfully, but these errors were encountered: