Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all Full Fx TFMs from SBRP #3282

Closed
7 tasks done
MichaelSimons opened this issue Mar 2, 2023 · 3 comments
Closed
7 tasks done

Remove all Full Fx TFMs from SBRP #3282

MichaelSimons opened this issue Mar 2, 2023 · 3 comments
Assignees
Labels
area-sbrp Source build reference packages

Comments

@MichaelSimons
Copy link
Member

MichaelSimons commented Mar 2, 2023

As part of #3014, all net4* TFMs are being trimmed from source-build. Once this work is completed, we expect a significant number of SBRPs will no longer be referenced and therefore will be removed. Of the remaining SBRPs, we expect there will be some that target net4* and net core TFMs. Because of this, we would still need to have the net4* targeting packs in SBRP which is not desirable.

In order to address this problem, the generate SBRP tooling will need to be updated to filter out the net4* TFMs. We can then regenerate the existing packages that reference net4* TFMs in order to "clean them up".

Full Fx TFMs to remove

@dotnet-issue-labeler dotnet-issue-labeler bot added area-prebuilts Reducing the number of prebuilt packages in the tarball untriaged labels Mar 2, 2023
@MichaelSimons MichaelSimons moved this to 8.0 Backlog in .NET Source Build Mar 2, 2023
@MichaelSimons MichaelSimons added area-sbrp Source build reference packages and removed area-prebuilts Reducing the number of prebuilt packages in the tarball untriaged labels Mar 2, 2023
@MichaelSimons MichaelSimons moved this from 8.0 Backlog to 8.0 Preview 4 in .NET Source Build Mar 14, 2023
@ViktorHofer
Copy link
Member

With the new reference source package generator that should be possible by adding the following here: net4*.

@MichaelSimons
Copy link
Member Author

All net 4* tfms have been removed now.

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Apr 20, 2023
@ViktorHofer
Copy link
Member

Congratulations - great milestone 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-sbrp Source build reference packages
Projects
Archived in project
Development

No branches or pull requests

2 participants