Skip to content

WPF binaries introduced into the VMR #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mthalman opened this issue Nov 17, 2023 · 11 comments · Fixed by dotnet/installer#19154
Closed

WPF binaries introduced into the VMR #3746

mthalman opened this issue Nov 17, 2023 · 11 comments · Fixed by dotnet/installer#19154
Assignees
Labels
area-additional-repos Adding additional contributing repos ops-monitor Issues created/handled by the source build monitor role

Comments

@mthalman
Copy link
Member

The following binaries from the wpf repo were introduced into the VMR by dotnet/installer#17746:

src/wpf/src/Microsoft.DotNet.Wpf/src/PresentationFramework/Resources/Hyphenation/Hyphen_en.hdict
src/wpf/src/Microsoft.DotNet.Wpf/src/PresentationFramework/Resources/Hyphenation/Hyphen_en.lex
src/wpf/src/Microsoft.DotNet.Wpf/src/ReachFramework/Resources/generated/Schemas_ContentTypes.resources
src/wpf/src/Microsoft.DotNet.Wpf/src/ReachFramework/Resources/generated/Schemas_CoreProperties.resources
src/wpf/src/Microsoft.DotNet.Wpf/src/ReachFramework/Resources/generated/Schemas_DiscardControl.resources
src/wpf/src/Microsoft.DotNet.Wpf/src/ReachFramework/Resources/generated/Schemas_DocStructure.resources
src/wpf/src/Microsoft.DotNet.Wpf/src/ReachFramework/Resources/generated/Schemas_OPC_DigSig.resources
src/wpf/src/Microsoft.DotNet.Wpf/src/ReachFramework/Resources/generated/Schemas_Relationships.resources
src/wpf/src/Microsoft.DotNet.Wpf/src/ReachFramework/Resources/generated/Schemas_S0.resources
src/wpf/src/Microsoft.DotNet.Wpf/src/ReachFramework/Resources/generated/Schemas_SignatureDefinitions.resources
src/wpf/src/Microsoft.DotNet.Wpf/src/ReachFramework/Resources/generated/Schemas_Versioning.resources
src/wpf/src/Microsoft.DotNet.Wpf/src/ReachFramework/Resources/generated/Schemas_xmldsig-core-schema.resources
src/wpf/src/Microsoft.DotNet.Wpf/src/Shared/Tracing/resources/MSG00001.bin
src/wpf/src/Microsoft.DotNet.Wpf/src/Shared/Tracing/resources/wpf-etwTEMP.BIN
src/wpf/src/Microsoft.DotNet.Wpf/src/WpfGfx/core/geometry/Scanner.doc

These need to be removed.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons MichaelSimons added area-additional-repos Adding additional contributing repos and removed untriaged labels Dec 7, 2023
@MichaelSimons MichaelSimons moved this from Backlog to Preview 1 in .NET Source Build Dec 7, 2023
@MichaelSimons
Copy link
Member

[Triage] @ViktorHofer is this something you can address?

@mmitche
Copy link
Member

mmitche commented Jan 3, 2024

Also part of #3738

This is in included in that t-shirt size costing.

@mthalman mthalman added the ops-monitor Issues created/handled by the source build monitor role label Jan 9, 2024
@ViktorHofer ViktorHofer removed their assignment Jan 17, 2024
@mthalman
Copy link
Member Author

These files are cloaked from the VMR as part of dotnet/installer#18280. There needs to be follow up to not rely on having these files exist in the repo.

@MichaelSimons MichaelSimons moved this from 9.0 Preview 1 to 9.0 Preview 2 in .NET Source Build Jan 29, 2024
@omajid
Copy link
Member

omajid commented Jan 31, 2024

Shall I do a PR to allow Scanner.doc? We allow .docx files and IMO .doc files should be treated identically.

@mthalman
Copy link
Member Author

Shall I do a PR to allow Scanner.doc? We allow .docx files and IMO .doc files should be treated identically.

Yes, that'd be great. In fact, that's what I had done in dotnet/installer#18280 but those changes won't be ported to the main branch.

@mmitche
Copy link
Member

mmitche commented Jan 31, 2024

Moved to In Progress.

@tkapin
Copy link
Member

tkapin commented Feb 1, 2024

To whom this should be assigned to?

@MichaelSimons
Copy link
Member

I think this is obsolete due to the change in direction described in #4088. Specifically #4087 will allow these and will need to modify the binary scan tool logic appropriately.

@mthalman mthalman removed the ops-monitor Issues created/handled by the source build monitor role label Feb 5, 2024
@mthalman
Copy link
Member Author

mthalman commented Feb 5, 2024

Removed the ops-monitor label since this isn't causing any build issues right now.

@mthalman mthalman added the ops-monitor Issues created/handled by the source build monitor role label Feb 5, 2024
@mthalman
Copy link
Member Author

mthalman commented Feb 5, 2024

Added back the label since it's still causing a warning on builds in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-additional-repos Adding additional contributing repos ops-monitor Issues created/handled by the source build monitor role
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants