Skip to content

Deal with binaries excluded from source build #3774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmitche opened this issue Dec 7, 2023 · 4 comments
Closed

Deal with binaries excluded from source build #3774

mmitche opened this issue Dec 7, 2023 · 4 comments

Comments

@mmitche
Copy link
Member

mmitche commented Dec 7, 2023

There are binaries currently excluded from source build (they were checked into the git repos). Most of these are required for building tests. Since we need to be able to build tests in the VMR, we need to have access to these files in some way shape or form. However, they cannot be introduced into the VMR because this violates rules about checked-in binaries in source-build.

Where these binaries exist, they should:

  • Remain excluded and deal with fallout (e.g. specific tests may never build in the VMR)
  • Factor out into packages that are restored when building in non Linux source-build scenarios.
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@mmitche
Copy link
Member Author

mmitche commented Jan 3, 2024

Adding back into Unified Build as this needs to be dealt with for UB completion.

Related: #3738

@mmitche mmitche added the Epic Groups multiple user stories. Can be grouped under a theme. label Jan 11, 2024
@mmitche
Copy link
Member Author

mmitche commented Jan 19, 2024

Closing in favor of #3989

@tkapin
Copy link
Member

tkapin commented Feb 15, 2024

I'm removing the Epic label to get this off of the roadmap, since it was closed in favor of #3989, which was in turn closed in favor of #4088.

@tkapin tkapin removed the Epic Groups multiple user stories. Can be grouped under a theme. label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants