Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only copy restored packages for source only builds #4194

Closed
mthalman opened this issue Mar 8, 2024 · 1 comment
Closed

Only copy restored packages for source only builds #4194

mthalman opened this issue Mar 8, 2024 · 1 comment
Labels
area-infra Source-build infrastructure and reporting untriaged

Comments

@mthalman
Copy link
Member

mthalman commented Mar 8, 2024

This issue stems from my comment at dotnet/installer#18824 (comment).

The CopyInnerBuildRestoredPackages task copies restored packages to the .packages directory at the repo root. AFAICT, this collection of packages is used as a means for prebuilt detection, which is done by the ReportPrebuiltUsage target. The issue is that this also gets executed for the unified-build where prebuilt detection isn't relevant. So in the unified-build it's wasting time and disk space for no purpose.

This should get cleaned up so it's only done for source builds. In addition, the ReportPrebuiltUsage target should get moved into the same file from where it's referenced.

@mthalman
Copy link
Member Author

mthalman commented Mar 15, 2024

Fixed by dotnet/installer#19072

In addition, the ReportPrebuiltUsage target should get moved into the same file from where it's referenced.

This can't be done because build.sourcebuild.targets isn't imported by repo-projects.

@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Source Build Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infra Source-build infrastructure and reporting untriaged
Projects
Archived in project
Development

No branches or pull requests

1 participant