Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebootstrap the VMR #4362

Closed
ellahathaway opened this issue Apr 30, 2024 · 3 comments
Closed

Rebootstrap the VMR #4362

ellahathaway opened this issue Apr 30, 2024 · 3 comments
Assignees
Labels
area-native-bootstrapping Allowing new platforms/operating systems to use source-build

Comments

@ellahathaway
Copy link
Member

ellahathaway commented Apr 30, 2024

Once dotnet/installer#19612 is merged and a build has been completed with the changes, the VMR needs to be rebootstrapped in order to resolve dotnet/sdk#40572 (comment).

dotnet/installer#19683 needs to be reverted after the rebootstrap as well.

Will close after we rebootstrap again and dotnet/installer#19683 gets reverted (for sdk)

@ellahathaway ellahathaway self-assigned this Apr 30, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added area-native-bootstrapping Allowing new platforms/operating systems to use source-build untriaged labels Apr 30, 2024
@ellahathaway
Copy link
Member Author

ellahathaway commented Apr 30, 2024

The build that I was going to pull the artifacts from failed when building Roslyn in Stage 2:

##[error]/vmr/src/roslyn/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/Core/CodeGeneration/CodeGenerationHelpers.cs(74,27): error CS0121: (NETCORE_ENGINEERING_TELEMETRY=Build) The call is ambiguous between the following methods or properties: 'string.Join(string?, ReadOnlySpan<object?>)' and 'string.Join(string?, ReadOnlySpan<string?>)'

If we rebootstrap, all the Stage 1 builds will fail with this same error.

cc @ViktorHofer @dotnet/source-build-internal

@ViktorHofer
Copy link
Member

ViktorHofer commented May 1, 2024

Let's try to get dotnet/installer#19594 in and then make a re-bootstrap. That includes the roslyn fix.

Ideally we would then send re-boostrap PRs into both sdk and installer.

@MichaelSimons
Copy link
Member

All required rebootstrapping work is complete. Closing.

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-native-bootstrapping Allowing new platforms/operating systems to use source-build
Projects
Archived in project
Development

No branches or pull requests

3 participants