Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package source mapping causes problems with VMR restores #4651

Closed
mmitche opened this issue Oct 7, 2024 · 2 comments · Fixed by dotnet/sdk#44076
Closed

Package source mapping causes problems with VMR restores #4651

mmitche opened this issue Oct 7, 2024 · 2 comments · Fixed by dotnet/sdk#44076
Assignees
Labels
area-infra Source-build infrastructure and reporting

Comments

@mmitche
Copy link
Member

mmitche commented Oct 7, 2024

Seen dotnet/sdk#43239

I think what is going on is when PSM is enabled in a repo, the VMR infra will see these and add PSM mappings for the local feeds that are added to nuget.config. But these additional mappings are often more specific than the ones in the repo already, so the repo's feeds are often ignored.

@mmitche mmitche converted this from a draft issue Oct 7, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added area-infra Source-build infrastructure and reporting untriaged labels Oct 7, 2024
@mmitche
Copy link
Member Author

mmitche commented Oct 7, 2024

@dotnet/source-build-internal and I think @NikolaMilosavljevic who did the VMR PSM work.

@NikolaMilosavljevic
Copy link
Member

We do add all specific mappings to original (online) sources, as well. So, VMR would be able to find them in all available sources. I could not repro this issue locally. Investigating further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infra Source-build infrastructure and reporting
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants