Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-build needs to accept the SDK version I gave it #578

Closed
eerhardt opened this issue May 25, 2018 · 3 comments
Closed

source-build needs to accept the SDK version I gave it #578

eerhardt opened this issue May 25, 2018 · 3 comments
Labels
area-native-bootstrapping Allowing new platforms/operating systems to use source-build

Comments

@eerhardt
Copy link
Member

When bootstrapping a new OS (or just building .NET Core from source in general), there are times when I don't have the exact version of the SDK that source-build wants. One case is where I build a bootstrap SDK, run a source-build, and then use the output of that first source-build to build again.

We currently export the SDK_VERSION environment variable based on the value in DotnetCLIVersion.txt:

export SDK_VERSION=$(cat $SCRIPT_ROOT/DotnetCLIVersion.txt)

  1. I would hope we could get rid of all the places that need this SDK_VERSION, but that is a long-term goal.
  2. In the meantime, we should instead get the correct version of the SDK we are using instead of the one that is checked into source. That way people don't need to edit source files just to get the build to work.

We can get the SDK version by executing dotnet --version.

@dseefeld dseefeld added triaged area-native-bootstrapping Allowing new platforms/operating systems to use source-build labels Jun 8, 2018
@omajid
Copy link
Member

omajid commented Aug 27, 2018

One case is where I build a bootstrap SDK, run a source-build, and then use the output of that first source-build to build again.

I had the same use case and the same exact issue.

A more general fix to improve this use case might be to provide the path to an entire SDK (not just the version) to the build. Source build can just pick it up from there and use it.

We should document the minimum/maximum version required for the SDK too.

@omajid
Copy link
Member

omajid commented Mar 11, 2020

Is this fixed by #1455 ?

@dagood
Copy link
Member

dagood commented Mar 11, 2020

I believe so--at some point this issue was duplicated by #1435, which we closed with #1455.
/cc @crummel

@dagood dagood closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-native-bootstrapping Allowing new platforms/operating systems to use source-build
Projects
None yet
Development

No branches or pull requests

4 participants