Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable net46 builds in source-build #592

Closed
crummel opened this issue Jun 7, 2018 · 5 comments
Closed

Enable net46 builds in source-build #592

crummel opened this issue Jun 7, 2018 · 5 comments
Assignees
Labels
area-product-experience Improvements in the end-user's product experience area-upstream-fix Needs a change in a contributing repo

Comments

@crummel
Copy link
Contributor

crummel commented Jun 7, 2018

End-to-end, this enables VS Code usage with source-build .NET Core (#125 -> dotnet/sdk#2249)

@crummel
Copy link
Contributor Author

crummel commented Jun 7, 2018

Related: dotnet/sdk#2309, #588.

@dleeapho dleeapho added area-upstream-fix Needs a change in a contributing repo triaged area-product-experience Improvements in the end-user's product experience labels Jun 7, 2018
@crummel crummel self-assigned this Jun 7, 2018
@markwilkie markwilkie added this to the S136 May 21 - June 8 (5/21/2018) milestone Jun 8, 2018
@dleeapho
Copy link
Contributor

@crummel Please test the E2E scenario with VS Code once PRs are merged.

@markwilkie markwilkie modified the milestones: S136 May 21 - June 8 (5/21/2018), S137 June 11 - June 29 (6/11/2018) Jun 13, 2018
@dagood
Copy link
Member

dagood commented Jun 13, 2018

Merged in #598. I'm going to try validating VS Code/Omnisharp with a local build I'm building of #610.

@dagood
Copy link
Member

dagood commented Jun 13, 2018

It works! 😄 (Fedora 28)

I extracted my source-built CLI, ran dotnet new console, then code . to make sure I see a "bad" status. The C# extension tells me it can't load the project. I add the extracted CLI to PATH, run code . again, and I get intellisense and F5 debugging.

@crummel
Copy link
Contributor Author

crummel commented Jun 13, 2018

Confirmed, I also get a working VS Code. dotnet --info output:

.NET Core SDK (reflecting any global.json):
 Version:   2.1.301
 Commit:    59524873d6

Runtime Environment:
 OS Name:     rhel
 OS Version:  7
 OS Platform: Linux
 RID:         rhel.7-x64
 Base Path:   /home/chris/dotnet/sdk/2.1.301/

Host (useful for support):
  Version: 2.1.1
  Commit:  N/A

.NET Core SDKs installed:
  2.1.301 [/home/chris/dotnet/sdk]

.NET Core runtimes installed:
  Microsoft.NETCore.App 2.1.1 [/home/chris/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

@dagood dagood closed this as completed Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-product-experience Improvements in the end-user's product experience area-upstream-fix Needs a change in a contributing repo
Projects
None yet
Development

No branches or pull requests

4 participants