Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ref-only packages in prebuilt report #866

Closed
dagood opened this issue Nov 13, 2018 · 4 comments
Closed

Include ref-only packages in prebuilt report #866

dagood opened this issue Nov 13, 2018 · 4 comments
Assignees
Labels
area-infra Source-build infrastructure and reporting

Comments

@dagood
Copy link
Member

dagood commented Nov 13, 2018

Including ref-only prebuilts as IL in the tarball is ok because the IL can be maintained, but it's still better if we can avoid them altogether. We should include these in the prebuilt report with proper annotations for tracking purposes. (Right now, they're just removed.)

@dagood dagood self-assigned this Nov 15, 2018
@dagood
Copy link
Member Author

dagood commented Nov 15, 2018

@dseefeld I'm thinking about how this affects the dashboard... would just adding an attribute to the AnnotatedUsage affect the packageversion count delta? Is that fixable? Or should I try something different like change the element name or only include it in the other (not annotated-usage.xml) files?

If an attribute is ok, another thought is that I should always include the annotation with true/false, so when/if they all go away it doesn't break the report like the test annotations.

@dagood
Copy link
Member Author

dagood commented Nov 15, 2018

I'm probably overthinking it and adding a RefOnlyPrebuilt="true/false" is fine. Let me know if something else would be better. 🙂

@dseefeld
Copy link
Contributor

Adding an attribute would work just fine. It won't affect the count delta. I agree with including it as "true/false" to prevent breaks.

@dseefeld
Copy link
Contributor

Ref-only prebuilts as IL was removed in 5.0. Tracking these no longer applies. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infra Source-build infrastructure and reporting
Projects
None yet
Development

No branches or pull requests

3 participants