Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze prebuilts for roslyn #891

Closed
dseefeld opened this issue Nov 16, 2018 · 3 comments
Closed

Analyze prebuilts for roslyn #891

dseefeld opened this issue Nov 16, 2018 · 3 comments
Assignees

Comments

@dseefeld
Copy link
Contributor

dseefeld commented Nov 16, 2018

The following prebuilt packages are included as dependencies in source-build by roslyn. These need to be analyzed to determine how to avoid requiring packages that source-build doesn’t build.

  1. Change to use the source-built version
  2. Package is not critical to product and can be removed. (i.e.test-specific, windows-specific, etc)
  3. The package is used as reference only
  4. The package should be built in source-build
  5. Other – please elaborate on what you think should be done.

For more detailed usage information for these, please see the Usage Exploration tab of the SourceBuildPrebuiltReport.

Prebuilt Status Updated 2019-06-24

Up to date prebuilt status can now be found in the SourceBuildPrebuiltReport in the Repo Status Data tab.

Prebuilt Table Updated 2019-05-07

PackageName PackageVersion SourceBuiltVersion Category
Microsoft.Build.Framework 15.1.548 16.0.461
Microsoft.Build.Tasks.Core 15.1.548 16.0.461
Microsoft.CSharp 4.3.0
Microsoft.CodeAnalysis.Analyzers 2.6.2-beta2
Microsoft.CodeQuality.Analyzers 2.6.2-beta2
Microsoft.DiaSymReader.Native 1.7.0
Microsoft.Net.Compilers.Toolset 3.1.0-beta1-19164-01 3.1.0-beta2-19067-14
Microsoft.NetCore.Analyzers 2.6.2-beta2
Microsoft.VisualStudio.Threading.Analyzers 15.8.209
Roslyn.Diagnostics.Analyzers 2.6.2-beta2
System.Collections.Immutable 1.5.0
System.Memory 4.5.2
System.Reflection.Metadata 1.6.0
System.Runtime.CompilerServices.Unsafe 4.5.2
System.Text.Encoding.CodePages 4.5.1
System.Threading.Tasks.Extensions 4.5.2

Original Prebuilt Table

PackageName PackageVersion SourceBuiltVersion Category
Microsoft.Build.Framework 15.1.548 16.0.0-preview.385 3
Microsoft.Build.Tasks.Core 15.1.548 16.0.0-preview.385 3
Microsoft.CSharp 4.3.0 3
Microsoft.CodeAnalysis.Analyzers 2.6.2-beta2 2
Microsoft.CodeQuality.Analyzers 2.6.2-beta2 2
Microsoft.DiaSymReader.Native 1.7.0 2
Microsoft.NETCore.Compilers 2.9.0-beta7-63018-03 3.0.0-beta3-19067-14 1
Microsoft.NetCore.Analyzers 2.6.2-beta2 2
Microsoft.VisualStudio.Threading.Analyzers 15.8.168 2
Roslyn.Diagnostics.Analyzers 2.6.2-beta2 2
System.Collections.Immutable 1.5.0 3*
System.IO.Pipes.AccessControl 4.3.0 3
System.Memory 4.5.1 3
System.Reflection.Metadata 1.6.0 3
System.Runtime.CompilerServices.Unsafe 4.5.0 4
System.Text.Encoding.CodePages 4.5.0 4
System.Threading.Tasks.Extensions 4.5.0 2
XliffTasks 0.2.0-beta-63004-01 0.2.0-beta-000048 5
@333fred
Copy link
Member

333fred commented Mar 26, 2019

@dseefeld updated the table. Some notes:

  • For things marked 2, by exclude we mean exclude from just sourcebuild, not exclude from the repo altogether.
  • For many things marked 3, especially things like System.Collections.Immutable, it's only a ref assembly if the version of SCI in the SDK is equal or bigger. We do require 1.5.0 as a minimum for reference.
  • For XliffTasks, the sourcebuild version needs to be updated.

For determining what we're using as just a reference assembly, I looked through our vbc/publish and csc/publish directories, and examined which of the above dlls were in there, and whether they were type forwards, ref assemblies, or full implementation assemblies. We only have CompilerServices and Text.Encoding.CodePages there, both of which are real implementations. Is there a better process or set of tools for determining this info?

@333fred
Copy link
Member

333fred commented Mar 26, 2019

Also, Microsoft.NETCore.Compilers, Roslyn is currently on a newer version than sourcebuild, and we'll likely prefer to update sourcebuild if at all possible.

@dseefeld
Copy link
Contributor Author

All prebuilts removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants