Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildCrossTargeting vs. buildMultiTargeting #151

Closed
bording opened this issue Aug 17, 2018 · 2 comments · Fixed by #441
Closed

buildCrossTargeting vs. buildMultiTargeting #151

bording opened this issue Aug 17, 2018 · 2 comments · Fixed by #441

Comments

@bording
Copy link

bording commented Aug 17, 2018

Looking at the SourceLink packages, I noticed that they have buildCrossTargeting folders. From what I understand, that was renamed to buildMultiTargeting (see NuGet/Home#4098).

Is there a reason to be using the older name?
@tmat tmat added the question Further information is requested label Aug 20, 2018
@tmat
Copy link
Member

tmat commented Aug 20, 2018

No reason, other than consistency with names used by msbuild and Microsoft.NET.Sdk.

@bording
Copy link
Author

bording commented Aug 20, 2018

Seems like it would eventually make sense to migrate everything to the newer name for the folder.

@tmat tmat removed the question Further information is requested label Oct 8, 2019
@tmat tmat mentioned this issue Oct 8, 2019
Merged
@tmat tmat closed this as completed in #441 Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up packaging tmat/sourcelink
2 participants
@tmat @bording