-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider capturing git the line break configuration in sourcelink json #613
Comments
I think the situation is more involved than those settings you've mentioned. If the repo has a |
Yes, but |
I guess I'm missing when you'd think those values would matter. Are you thinking of cases where the repo doesn't have a |
Yes, also in case when |
This change in .NET SDK added assembly-level attribute with git repo clone URL: dotnet/sdk#11559
This can be used to optimize download of all source file required to build the dll. If however, the git configuration (specifically
core.eol
andcore.autocrlf
settings) differ between the server that originally built the DLL and the local repo the re-build will produce different binaries.It would thus be useful to record the git settings in Source Link record so that the clone can be configured the same as the build server that produced the binary.
Note: Check if git line conversion changes the BOM.
The text was updated successfully, but these errors were encountered: