Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Spark nuget package shouldn't work on all TFMs #37

Closed
eerhardt opened this issue Apr 24, 2019 · 0 comments · Fixed by #54
Closed

Microsoft.Spark nuget package shouldn't work on all TFMs #37

eerhardt opened this issue Apr 24, 2019 · 0 comments · Fixed by #54
Labels
good first issue Good for newcomers

Comments

@eerhardt
Copy link
Member

eerhardt commented Apr 24, 2019

The Microsoft.Spark nuget package has a build\Microsoft.Spark.targets file. Since this file isn't contained in a TFM folder, nuget will think this package works on any TFM, even TFMs that aren't compatible with netstandard2.0.

See dotnet/machinelearning#370 for the same issue that came up in ML.NET.

We should move that .targets file into a build\netstandard2.0 folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants