Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise error message on conflicting templates #3275

Closed
1 task
vlada-shubina opened this issue Jun 10, 2021 · 2 comments
Closed
1 task

Revise error message on conflicting templates #3275

vlada-shubina opened this issue Jun 10, 2021 · 2 comments
Labels
need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Milestone

Comments

@vlada-shubina
Copy link
Member

vlada-shubina commented Jun 10, 2021

image
in case there are multiple templates coming from different group with same name the error message is confusing.

Revise error message:

  • if short name are same and languages are same, the CTA should be to uninstall one of the packages
  • if languages are different, suggest to use --language option
  • if short names are different can stay as it (though it is unlikely case after moving to exact match on short name

TODO:

@vlada-shubina vlada-shubina added triaged The issue was evaluated by the triage team, placed on correct area, next action defined. need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases labels Jun 14, 2021
@vlada-shubina vlada-shubina added this to the July Sprint milestone Jun 14, 2021
@baronfel
Copy link
Member

baronfel commented Nov 17, 2021

This sounds reasonable to me, though this is another thing that might be helped by better validation for template authors. Since we have the template manifest, during the Pack of a template we could emit a warning if the desired short name would conflict with another known tool. The idea would be to push this error to the author instead of to the template consumer.

@vlada-shubina
Copy link
Member Author

vlada-shubina commented Mar 25, 2022

The error message was fixed while migrating to new parser, the new output is below:

Unable to resolve the template, the following installed templates are conflicting:
Identity                         Template Name       Short Name     Language  Author      Package
%TABLE HEADER DELIMITER%
Invalid.SameShortName.TemplateA  Invalid.SameSho...  sameshortname            Test Asset  %TEMPLATE LOCATION%
Invalid.SameShortName.TemplateB  Invalid.SameSho...  sameshortname            Test Asset  %TEMPLATE LOCATION%

Uninstall the template packages containing the templates to keep only one template from the list or add the template options which differentiate the template to run.

This is not yet perfect, as still there is no way to run the templates that have same name. We plan to improve this behavior in #4135.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Projects
None yet
Development

No branches or pull requests

2 participants