Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

NotSupportedException should clarify which project failed #273

Closed
BrannonKing opened this issue Apr 7, 2020 · 6 comments
Closed

NotSupportedException should clarify which project failed #273

BrannonKing opened this issue Apr 7, 2020 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@BrannonKing
Copy link

I've been attempting to convert a solution that contains about 400 project files. About half way through it fails with this error below. The difficulty is that it doesn't say which particular project failed. It might be nice to have a log message stating which project it was attempting to convert.

System.NotSupportedException: This project has custom imports in a manner that's not supported.
   at MSBuild.Abstractions.MSBuildWorkspace.CreateSdkBaselineProject(String projectFilePath, IProject project, IProjectRootElement root, ImmutableDictionary`2 configurations) in /_/src/MSBuild.Abstractions/MSBuildWorkspace.cs:line 100
   at MSBuild.Abstractions.MSBuildWorkspace..ctor(ImmutableArray`1 paths, Boolean noBackup) in /_/src/MSBuild.Abstractions/MSBuildWorkspace.cs:line 49
   at MSBuild.Abstractions.MSBuildWorkspaceLoader.LoadWorkspace(String path, Boolean noBackup) in /_/src/MSBuild.Abstractions/MSBuildWorkspaceLoader.cs:line 45
   at MSBuild.Conversion.Program.Run(String project, String workspace, String msbuildPath, Boolean diffOnly, Boolean noBackup) in /_/src/try-convert/Program.cs:line 73
@BrannonKing
Copy link
Author

Issue #124 helped me track down which project was failing.

@cartermp cartermp added enhancement New feature or request help wanted Extra attention is needed labels Apr 7, 2020
@cartermp
Copy link
Contributor

cartermp commented Apr 7, 2020

Thanks for filing. I think this would be perfectly fine to add as an enhancement. Probably a fairly easy adjustment.

@dotnokato
Copy link
Contributor

I can work on that.
Do we want to include full path or just the project file name?

@jmarolf
Copy link
Contributor

jmarolf commented Apr 9, 2020

I assume that giving the full project path would be the most helpful

@dotnokato
Copy link
Contributor

@BrannonKing Can you check on current version from master if this is what you needed?

@cartermp
Copy link
Contributor

I'll close this out - thanks @dotnokato for the fix in #274

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants