Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Maestro to its own repository #83

Open
dagood opened this issue Oct 6, 2016 · 8 comments
Open

Move Maestro to its own repository #83

dagood opened this issue Oct 6, 2016 · 8 comments

Comments

@dagood
Copy link
Member

dagood commented Oct 6, 2016

There's no pressing need to do this, but some soft reasons Maestro doesn't fit here:

  • Maestro listens to other repos too, not just build-info changes.
  • Changes under the Maestro path (typically subscription updates) are independent of build-info changes.
  • All changes to build-infos are automated, with the small exception of manual fixups. All changes to Maestro are manual subscription changes.
  • Many teams will want to write to and read from build-infos for build coordination, but Maestro is a service.

No concrete plan to make the move--for now, it's waiting for a hard reason.

/cc @naamunds @dleeapho

@markwilkie
Copy link
Member

I recommend we make any improvements in this area in concert with the work to build from source.

/cc @ellismg

@deeprobin
Copy link

Maestro still uses .NET Framework.

If there is interest (and Maestro has not yet been replaced by anything else) I can create a small Maestro rewrite.

But I would like to ask a maintainer if we still need Maestro in the long run.

@dagood
Copy link
Member Author

dagood commented Mar 25, 2022

If there is interest (and Maestro has not yet been replaced by anything else) I can create a small Maestro rewrite.

Maestro is still being used fairly heavily, but I'm not sure if there's interest in updating it (let alone a rewrite). However, I would recommend asking at https://github.com/dotnet/arcade/issues for a definitive answer from the team that maintains it now.

@markwilkie
Copy link
Member

Hi @deeprobin - curious what you'd like to see Maestro do that it currently doesn't and the application?

Cheers

@deeprobin
Copy link

deeprobin commented Mar 28, 2022

@markwilkie
I'm only concerned with the project structure. Since Maestro has only very limited something to do with this repo.

In this course, I think an upgrade to .NET 6 (or possibly 7) would be appropriate (but consider this only as optional for now).

@mmitche
Copy link
Member

mmitche commented Mar 28, 2022

Note that there are two Maestros:

  • This one (legacy)
  • New Maestro, which is primary focused on dependency flow.

I think legacy Maestro will gradually be replaced over time, and I don't think a rewrite has a ton of value at this point. Ultimately, it's really just a web app that launches AzDO pipelines when files change in a repo.

@deeprobin
Copy link

@mmitche
Allright. I haven't gone that deep into the matter yet.
I thought there was only one Maestro.

How many use cases do we still have from the legacy Maestro in the Foundation?
It would make sense to migrate to the new Maestro in the long term and to remove the Legacy Maestro from this repository (and move it to an archive repository if necessary).

@mmitche
Copy link
Member

mmitche commented Mar 28, 2022

It's mainly used for code mirroring and inter-branch merge PR generation these days.

Code mirroring will probably move into new Maestro (it's inefficient as it is), and the inter-branch merge generation could probably be moved to fabric bot or something like that. Haven't looked into it too closely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants