Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please ignore keywords such as 'if' inside strings. #1141

Closed
borgdylan opened this issue Jan 24, 2017 · 6 comments
Closed

Please ignore keywords such as 'if' inside strings. #1141

borgdylan opened this issue Jan 24, 2017 · 6 comments
Assignees
Milestone

Comments

@borgdylan
Copy link

Environment data

dotnet --info output:
.NET Command Line Tools (1.0.0-preview3-003236)

Product Information:
Version: 1.0.0-preview3-003236
Commit SHA-1 hash: 8f00e03c43

Runtime Environment:
OS Name: ubuntu
OS Version: 16.10
OS Platform: Linux
RID: ubuntu.16.10-x64

VS Code version: 1.9.0 insider
C# Extension version: 1.6.2

Steps to reproduce

Put some code such as an if statement inside a string.

Expected behavior

I expect the string to be highlighted normally as it was in the 1.5.x versions of the extension.

Actual behavior

The keywords get highlighted as if they were not inside a string literal.

@borgdylan
Copy link
Author

borgdylan commented Jan 24, 2017

The issue also existed in v. 1.6.1. For me, the last known good C# syntax file was shipped in v. 1.5.3

@DustinCampbell
Copy link
Member

This should already be fixed with #1115. Could you the latest beta release here to verify? Use these instructions to install the beta: https://github.com/OmniSharp/omnisharp-vscode/wiki/Installing-Beta-Releases

@DustinCampbell DustinCampbell added this to the 1.7 milestone Jan 24, 2017
@DustinCampbell DustinCampbell self-assigned this Jan 24, 2017
@DustinCampbell
Copy link
Member

And, if you don't want to take the time to install a beta release, please feel free to provide a code sample and I'll verify the highlighting.

@borgdylan
Copy link
Author

I'll take a backup of my current extension install and verify it.

@borgdylan
Copy link
Author

I confirm that not only is the issue fixed, but also that the highlighting looks richer and nicer than ever before! It looks on par with the TS grammar.

@DustinCampbell
Copy link
Member

Excellent! That was definitely the goal. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants