Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Extract Method' right click action takes precedence over breakpoint's context menu #1615

Closed
ClaireKang opened this issue Jul 3, 2017 · 4 comments

Comments

@ClaireKang
Copy link

ClaireKang commented Jul 3, 2017

Environment data

dotnet --info output:
Runtime Environment:
OS Name: Ubuntu16.10
SDK: 1.0.4
VS Code version: 1.13.1
C# Extension version: v1.12.0-beta1

Steps to reproduce

  1. Create a new project in Command with 'dotnet new console' ->'dotnet restore'.
  2. Open project with VSCode.
  3. Move cursor to line 9
  4. Hit F9 to set a breakpoint
  5. Right-Click the breakpoint to edit it.

Expected behavior

image

Actual behavior

image

Work around

Move the cursor to another line

@gregg-miskelly gregg-miskelly changed the title Debugger: Only display 'Extract Method' when Right-Click on breakpoint that set with 'F9'. 'Extract Method' right click action takes precedence over breakpoint's context menu Jul 3, 2017
@DustinCampbell
Copy link
Member

There's two issues here:

  1. Extract Method shouldn't be offered when there isn't a selection in the editor. I'm tracking this with Selection-based refactorings should not appear when there is no selection #1605 and already have a fix in hand for it.
  2. VS Code shouldn't hide the light bulb with breakpoints and then offer the light bulb menu instead of the breakpoint menu. That's an issue that will need to be fixed within VS Code. The nearest issue I could find is can't create breakpoint on current line because light bulb is in the way microsoft/vscode#25174. @jrieken, does this look like the same problem to you?

@jrieken
Copy link
Contributor

jrieken commented Jul 10, 2017

hm, @isidorn might know...

@isidorn
Copy link
Contributor

isidorn commented Jul 17, 2017

Yeah microsoft/vscode#25174 covers the issue 2. quite well

@JoeRobich
Copy link
Member

Cannot reproduce with current release.

@JoeRobich JoeRobich closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants