Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.58 and take advantage of the new completion labels #4640

Closed
333fred opened this issue Jul 8, 2021 · 3 comments · Fixed by #4648
Closed

Update to 1.58 and take advantage of the new completion labels #4640

333fred opened this issue Jul 8, 2021 · 3 comments · Fixed by #4648

Comments

@333fred
Copy link
Member

333fred commented Jul 8, 2021

https://code.visualstudio.com/updates/v1_58#_detailed-completion-item-labels

Should let us display more info for types of things and the namespace import completions will bring in. Related to microsoft/vscode#39441.

@333fred
Copy link
Member Author

333fred commented Jul 8, 2021

@david-driscoll these are also in the 3.17 draft LSP spec (https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#completionItemLabelDetails), so we could do similar for LSP in general when clients support it.

@JoeRobich
Copy link
Member

It is neat in the TypeScript completion that you can see the member declaration inlined.
image

@333fred
Copy link
Member Author

333fred commented Jul 12, 2021

It is neat in the TypeScript completion that you can see the member declaration inlined.

For this, btw, we'll need new Roslyn APIs. Currently, that's a section in the documentation that's retrieved by the resolve step, and I don't want to try and resolve all documentation for every completion item on completion list pop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants