Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types not highlighted in variable and field declarations #687

Closed
ivanz opened this issue Aug 18, 2016 · 4 comments
Closed

Types not highlighted in variable and field declarations #687

ivanz opened this issue Aug 18, 2016 · 4 comments

Comments

@ivanz
Copy link
Contributor

ivanz commented Aug 18, 2016

Copy from: atom/language-csharp#48

I'm using the VSCode Version 0.10.6 (0.10.6).
Default dark theme.

Here's a sample code:

class MyClass
{

}

class Program
{
    static void Main()
    {        
        //string is highlighted
        string s = "MyClass";

        //MyClass is not highlighted
        MyClass myClass = new MyClass();
    }
}

Here's an image:
image

Here's a video demonstration:
https://www.youtube.com/watch?v=VpRPJc42FZQ

@johanneskopf
Copy link

That's a duplicate of issue #674

@ivanz
Copy link
Contributor Author

ivanz commented Aug 18, 2016

I thought 674 was about semantic highlighting where as I am thinking about simple regex rule that matches field and variable declarations and highlights the "type" bit - we already do this for properties and methods.

@johanneskopf
Copy link

johanneskopf commented Aug 18, 2016

You mean it's possible to highlight the first Vector3 in
"Vector3 x = new Vector3(0f, 0f, 0f);"
but it's difficult to hightlight Debug in
"Debug.Log("test");"
Is this correct?

@DustinCampbell
Copy link
Member

Yes, that's right. Syntactically, there's no difference between "Debug" being a class or property, so we can't color it as a type. It's also impossible to highlight Vector3 differently if it's a class vs. a struct, which is something we do in VS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants