[NETE2ESDK] The parameter architecture and requesting should not be case sensitive in the Find Path feature.

[NicoleWang001]

Describe the bug.
If the value of parameter architecture and requesting contains uppercase letters, discovering .NET path is failed

Please attach log file(s) here if you have any.
The log file location should be copied to your clipboard if you came from VS Code.

Reproduction Steps
1.Download X64 SDK from https://dotnet.microsoft.com/en-us/download/dotnet and install.
2.Open VS Code and Run the 'Sample: Find the.NET on the PATH' command.
3. Enter the value of parameter architecture and requesting contains uppercase letters, eg. 'X64', or 'Greater_than_or_equal'
4.observe

Expected Behavior
.NET installation path should be found correctly

Exceptions & Errors (if any)
It returns non .NET installation path is found.

.NET Install Tool Version
Preview 2.2.1

Your operating system? Please provide more detail, such as the version and or distro above.
N/A

VS Code Version
1.94.2

[nagilson]

This is a good point, though this api will only be called by other code which will user lowercase version, so I would take this as a good first issue or open source thing to just lowercase the architecture string passed in here to the API.

[nagilson]

@NicoleWang001 Going forward, please don't include this issue in the table of issues. I think this is a good thing to raise and for us to fix, but it is low priority for the reasons above. I don't think we will fix it until there is someone we want to onboard to the repo or there is an open source person who wants to do it.

[agarwalishita]

I can pick up this bug

[nagilson]

Thank you @agarwalishita 😄 Ill be happy to review your PR if so

[agarwalishita]

Unable to find .net runtime architecture command here. Is there specific extension required for this command?

[nagilson]

You will need to run the Sample extension to run the find path command as shown in the issue 😉

To do that you will need to build and then open the debug tab. Then in the debug tab you can select the sample extension drop down. Or, you can pack the sample extension as a .vsix file using vsce and then run the runtime extension to debug the code. There are some details about this in the readme of the repo.

The code in question is here, btw:

vscode-dotnet-runtime/sample/src/extension.ts

Line 203 in c269248

const arch = await vscode.window.showInputBox({

[v-xiaofchen]

This issue does not repro on 2.2.3.

[agarwalishita]

@nagilson you can close this issue as #2009 PR is merged