Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Semver Library #2003

Open
nagilson opened this issue Oct 25, 2024 · 4 comments
Open

Use Semver Library #2003

nagilson opened this issue Oct 25, 2024 · 4 comments
Assignees
@nagilson
Labels
enhancement New feature or request P2

Comments

@nagilson
Copy link
Member

Instead of manually coding all of our version parsing, we should probably migrate to the semver library.
#2000 (comment) Please see this for more information.
@nagilson nagilson mentioned this issue Oct 25, 2024
Merged
@nagilson nagilson added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers P2 labels Oct 25, 2024
@agarwalishita
Copy link
Contributor

Can you please assign this issue on my name?
Since it's a first contribution, I may connect with you for more information.

@nagilson
Copy link
Member Author

Absolutely, I would be happy to :) This will be replacing some of the logic in the VersionUtilities and the code that references them, as well as the logic mentioned in the PR above.

@nagilson
Copy link
Member Author

nagilson commented Nov 4, 2024 •
edited
Loading

I need to make an urgent change regarding this, so for this task I am going to pick it up now. Apologies.

@nagilson nagilson assigned nagilson and unassigned agarwalishita Nov 4, 2024
@nagilson
Copy link
Member Author

nagilson commented Nov 4, 2024 •
edited
Loading

This isn't really a simple fix. We need to support '9.0' and '9' as versions but those are not valid semver versions without loose or coercion mode

@nagilson nagilson removed help wanted Extra attention is needed good first issue Good for newcomers labels Nov 4, 2024
@nagilson nagilson mentioned this issue Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nagilson nagilson

Labels
enhancement New feature or request P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nagilson @agarwalishita