Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root_Certificate_Installed [CondtionalFact] is not aware of Linux nuances #1380

Closed
iamjasonp opened this issue Jul 19, 2016 · 3 comments
Closed
Assignees
Labels
infrastructure Issues related to the build, packaging, testing or related areas.
Milestone

Comments

@iamjasonp
Copy link
Member

Root_Certificate_Installed will check whether or not a certificate is installed on the box, but only by using the X509 APIs available to .NET.

In Linux/OS X, we must also install the certificate to the system's root store for HTTP scenarios to work; merely installing it to the user root store will not work - which is what Root_Certificate_Installed does.

We either need to:

  • Split up the ConditionalFact to be aware of this nuance, or
  • (Preferred) Have the ConditonalFact also check for installation in the machine root store, and return false if not available. This might reduce some coverage we get in Helix, but we can rely on CI to give us coverage in that area
@roncain
Copy link
Contributor

roncain commented Jul 19, 2016

@iamjasonp -- the other option is to not make the ConditionalFact detector smarter but to insist the CI and VSO scripts set Root_Certificate_Installed=true. Of course we need to find a way to install to the right stores on Linux in our VSO runs (#1304). We need to make a call on how much we expect to rely on the detectors.

@zhenlan zhenlan added the infrastructure Issues related to the build, packaging, testing or related areas. label Jul 19, 2016
@zhenlan zhenlan added this to the 2016.07 milestone Jul 19, 2016
@zhenlan
Copy link
Member

zhenlan commented Jul 19, 2016

@iamjasonp will open corefx bug for consistent cert install behavior on all platforms
We will fix the infrastructure test to make sure certs are installed in system root store as well.
All tests on CI should pass once Jason's cert install script are hooked up.
Http tests will fail on Helix lab run until we figure out a way to install cert in system root store.

@iamjasonp
Copy link
Member Author

iamjasonp commented Aug 3, 2016

All these items are complete, so closing off this bug. There is a PR out to fix install on OpenSUSE.

All tests on CI should pass once Jason's cert install script are hooked up.

Note that this statement isn't true 😄 it means that tests requiring the Root_Certificate_Installed condition will pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to the build, packaging, testing or related areas.
Projects
None yet
Development

No branches or pull requests

3 participants