Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets tests hang in Linux #463

Closed
roncain opened this issue Oct 26, 2015 · 6 comments
Closed

WebSockets tests hang in Linux #463

roncain opened this issue Oct 26, 2015 · 6 comments
Assignees
Labels
bug This is a product bug. Linux An issue specific to Linux.
Milestone

Comments

@roncain
Copy link
Contributor

roncain commented Oct 26, 2015

All WebSockets tests hang in Linux. They eventually timeout but after a very long time. In addition to a fix, it would be nice to have a shorter timeout in the tests to avoid the pain.

=== TEST EXECUTION SUMMARY ===
Security.TransportSecurity.Tests Total: 9, Errors: 0, Failed: 8, Skipped: 0, Time: 6.471s
One or more tests failed while running tests from 'Security.TransportSecurity.Tests'. Exit code 8.
Binding_NetHttp_WebSocketTests.RequestResponseOverWebSocketManually_Echo_RoundTrips_Guid [FAIL]
System.TimeoutException : Not completed within the alloted time of 00:20:00
Stack Trace:
at WcfDuplexServiceCallback.get_CallbackGuid()
at Binding_NetHttp_WebSocketTests.RequestResponseOverWebSocketManually_Echo_RoundTrips_Guid()
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
Binding_NetHttp_WebSocketTests.DuplexOverWebSocket_Echo_RoundTrips_Guid [FAIL]
System.TimeoutException : Not completed within the alloted time of 00:20:00
Stack Trace:
at WcfDuplexServiceCallback.get_CallbackGuid()
at Binding_NetHttp_WebSocketTests.DuplexOverWebSocket_Echo_RoundTrips_Guid()
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
Binding_NetHttp_WebSocketTests.TransportUsageAlways_WebSockets_Synchronous_Call [FAIL]
System.TimeoutException : Not completed within the alloted time of 00:20:00
Stack Trace:
at WcfDuplexServiceCallback.get_CallbackGuid()
at Binding_NetHttp_WebSocketTests.TransportUsageAlways_WebSockets_Synchronous_Call()
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
Finished: Binding.NetHttp.Tests

@roncain roncain added bug This is a product bug. Linux labels Oct 26, 2015
@zhenlan zhenlan added this to the 2015.11 milestone Oct 27, 2015
@mconnew
Copy link
Member

mconnew commented Nov 5, 2015

Although we are skipping these tests on Linux now, the fix will be to make the call throw an exception instead of swallowing it somewhere.

@roncain
Copy link
Contributor Author

roncain commented Dec 2, 2015

@mconnew -- that would eliminate the hang but only make us aware where it actually failed. I recommend that after you add the exception throwing code, we retitle this to "WebSocket tests fail in Linux" and reassign as appropriate. There is no other issue I am aware of tracking WS in Linux.

@zhenlan zhenlan modified the milestones: 2015.11&12, 2016.01 Dec 15, 2015
@zhenlan zhenlan modified the milestones: 2016.01, 2016.02 Feb 2, 2016
@zhenlan zhenlan modified the milestones: 2016.02, 2016.03 Mar 1, 2016
@zhenlan
Copy link
Member

zhenlan commented Mar 29, 2016

@roncain can you please look into a fix of this issue?

@zhenlan zhenlan added Linux An issue specific to Linux. and removed Ubuntu labels Mar 30, 2016
@zhenlan zhenlan modified the milestones: 2016.04, 2016.03 Apr 12, 2016
@zhenlan zhenlan removed this from the 2016.04 milestone May 3, 2016
@zhenlan zhenlan modified the milestones: 2016.05, 2016.04 May 3, 2016
@zhenlan zhenlan modified the milestones: 2016.06, 2016.05 May 18, 2016
@roncain
Copy link
Contributor Author

roncain commented Jun 22, 2016

Update: only the following 3 WS tests timeout. All others say "Web sockets is not supported on this platform".

WebSocketTests.WebSocket_Http_WSTransportUsageAlways_DuplexCallback_GuidRoundtrip
WebSocketTests.WebSocket_WSScheme_WSTransportUsageAlways_DuplexCallback_GuidRoundtrip
WebSocketTests.WebSocket_Http_WSTransportUsageDefault_DuplexCallback_GuidRoundtrip

All 3 fail with the error:
"System.TimeoutException : Not completed within the alloted time of 00:01:00:

@roncain
Copy link
Contributor Author

roncain commented Jun 22, 2016

Now that this issue is related to only 3 tests, and they all "successfully" timeout after 1 minute, does it make sense to continue investigating this before we have fixed #420 assigned to @mconnew? I tried enabling all WS tests, and on Ubuntu they all say "WS not supported on this platform" except for the 3 mentioned in this current issue.

/cc @zhenlan @mconnew

@zhenlan
Copy link
Member

zhenlan commented Jun 24, 2016

Since this is not as bad as before (hang for 20 minutes) anymore, I think it's okay to not do anything with this issue and wait Matt to validate that the WebSocket on Linux is fixed.

@zhenlan zhenlan assigned mconnew and unassigned roncain Jul 12, 2016
@zhenlan zhenlan modified the milestones: 2016.07, 2016.06 Jul 12, 2016
@zhenlan zhenlan closed this as completed Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a product bug. Linux An issue specific to Linux.
Projects
None yet
Development

No branches or pull requests

4 participants