Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage #917

Closed
danmoseley opened this issue May 2, 2019 · 3 comments
Closed

Increase code coverage #917

danmoseley opened this issue May 2, 2019 · 3 comments
Labels
test-enhancement Improvements of test source code
Milestone

Comments

@danmoseley
Copy link
Member

I didn't see an issue for this already (feel free to close if there is one). Looks like coverage is less than 30%.

@@                 Coverage Diff                 @@
##              master        #914         +/-   ##
===================================================
- Coverage   28.94861%   28.94235%   -0.00626%     
===================================================
  Files           1083        1083                 
  Lines         294135      294133          -2     
  Branches       38407       38407                 
===================================================
- Hits           85148       85129         -19     
- Misses        204950      204965         +15     
- Partials        4037        4039          +2

@hughbe you've spent more time looking at the code/tests than many of us, how feasible do you think it is to get this number up? That would help increase confidence in the upcoming release, for sure - and make refactors less risky.

I wonder if the debt could be categorized somehow eg by namespace to make this easier to drive.

@zsd4yr
Copy link
Contributor

zsd4yr commented May 3, 2019

We have a user epic issue tracking functional testing parity with Core. #672

We have about 100-200 apps which are used in testing automation using Maddog in the .NET FX, and we've had an enormous backlog item to get them driven by xunit and incorporated into our CI.

As far as I know, this will not change the number above representing our Code Coverage but it will increase the surface area over which we test. @sharwell may have a better idea about that.

@zsd4yr
Copy link
Contributor

zsd4yr commented May 3, 2019

For tracking down the areas for our code coverage, if you click any of the buttons for code coverage on the top-level README here: https://github.com/dotnet/winforms#code-coverage

You will be directed to an interactive dashboard showing what parts of our code have coverage in xunit tests. https://codecov.io/gh/dotnet/winforms

In particular, the outermost rings of the sunburst chart may be what you are looking for. Click on it For example, here is the sunburst for System.Windows.Forms src:

image

I would also recommend looking through the files tab https://codecov.io/gh/dotnet/winforms/tree/master/src

image

For example, by exploring the Files, you can hone in on that although System.Windows.Forms.Design has very low code coverage, that low code coverage is not really in Drawing/Design

image

@merriemcgaw merriemcgaw added the test-enhancement Improvements of test source code label May 3, 2019
@merriemcgaw merriemcgaw added this to the Future milestone May 3, 2019
@zsd4yr zsd4yr closed this as completed May 3, 2019
@zsd4yr zsd4yr reopened this May 3, 2019
@RussKie RussKie modified the milestones: Future, 7.0 Aug 27, 2021
@merriemcgaw merriemcgaw modified the milestones: .NET 7.0, .NET 8.0 Aug 11, 2022
@JeremyKuhne JeremyKuhne modified the milestones: .NET 8.0, .NET 9.0 Aug 15, 2023
@Tanya-Solyanik
Copy link
Member

Superseded by another item - #10453

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-enhancement Improvements of test source code
Projects
None yet
Development

No branches or pull requests

6 participants