Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THIRD-PARTY-NOTICES.txt file contains test-only notices #9905

Closed
NikolaMilosavljevic opened this issue Sep 13, 2023 · 1 comment · Fixed by #9906
Closed

THIRD-PARTY-NOTICES.txt file contains test-only notices #9905

NikolaMilosavljevic opened this issue Sep 13, 2023 · 1 comment · Fixed by #9906
Assignees
@lonitra

Comments

@NikolaMilosavljevic
Copy link
Member

Test-only notices should not be included in the main repo's TPN file: https://github.com/dotnet/winforms/blob/main/THIRD-PARTY-NOTICES.TXT

Please remove this notice and include it alongside tests that need it. See this as an example: https://github.com/dotnet/runtime/blob/main/src/tests/JIT/Performance/CodeQuality/Burgers/THIRD-PARTY-NOTICES

This issue was uncovered while updating TPN file for .NET 8 release: dotnet/runtime#91933 The process assembles notices from all repos into a shared TPN file that ships with SDK.
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Sep 13, 2023
Merged
@lonitra lonitra self-assigned this Sep 13, 2023
@lonitra lonitra mentioned this issue Sep 13, 2023
Merged
@ghost ghost added the 🚧 work in progress Work that is current in progress label Sep 13, 2023
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Sep 13, 2023
@John-Qiao
Copy link
Member

Verified it in the main branch of Winforms repo for .Net 9.0, the content of THIRD-PARTY-NOTICES.TXT is changed to below:

9905-testresult

@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lonitra lonitra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Place Test-Only Notice Alongside Test lonitra/winforms
3 participants
@NikolaMilosavljevic @lonitra @John-Qiao