Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRT] Fix DRT failure in DRTPrinting #1054

Closed
grubioe opened this issue Jun 21, 2019 · 3 comments
Closed

[DRT] Fix DRT failure in DRTPrinting #1054

grubioe opened this issue Jun 21, 2019 · 3 comments
Labels
issue-type-test-bug Problem in test source code (most likely) rank40 Rank: Priority/rank on a scale of (1..100)
Milestone

Comments

@grubioe
Copy link
Contributor

grubioe commented Jun 21, 2019

Fix all failures outlined in following table:

Feature Test Case Reproduced OS Log Bugs:
Printing DrtPrinting() Failed OS: Win81 x86, Win2K12, RS1 x86, RS1 ServerStandard, RS5 x64, RS6 x86 DrtPrinting() DrtPrinting()-RS5&&RS6 #597

Printing is also currently failing due to being unable to locate System.Management.dll (test issue)

EDIT: This now only fails on RS1, 8.1, and 2k12R2.

@grubioe grubioe added issue-type-test-bug Problem in test source code (most likely) needs-updated-estimate This issue needs an updated estimate labels Jun 21, 2019
@grubioe grubioe added this to the 3.0 milestone Jun 21, 2019
@grubioe grubioe removed the needs-updated-estimate This issue needs an updated estimate label Jun 21, 2019
@grubioe grubioe added the rank40 Rank: Priority/rank on a scale of (1..100) label Jul 16, 2019
@stevenbrix
Copy link
Contributor

The following tests were fixed with this internal PR:

  • DrtXpsApi
  • DrtDigitalSignature
  • DrtPackagingApis

The following tests were removed since they tested functionality inside WPF that no longer exists with this commit:

  • DrtZipIO
  • DrtInterleavedPackage

@grubioe grubioe assigned ojhad and rladuca and unassigned stevenbrix Jul 29, 2019
@rladuca rladuca changed the title [DRT] Fix DRT failures for DataServices, FlowLayout, DigitalDocuments, Printing, XAML [DRT] Fix DRT failure in DRTPrinting Jul 31, 2019
@rladuca
Copy link
Member

rladuca commented Jul 31, 2019

Repurposing this bug solely for DrtPrinting, all other bugs mentioned are either fixed or are in another issue that will fix them. Updating the estimate accordingly.

@rladuca rladuca removed their assignment Jul 31, 2019
@grubioe grubioe modified the milestones: 3.0, 3.1 Aug 21, 2019
@grubioe grubioe assigned rladuca and unassigned ojhad Sep 4, 2019
@grubioe grubioe modified the milestones: 3.1, 5.0 Oct 8, 2019
@rladuca rladuca removed their assignment Jan 28, 2020
@rladuca rladuca self-assigned this Mar 5, 2020
@rladuca
Copy link
Member

rladuca commented Apr 24, 2020

DrtPrinting is failing due to the following:

https://github.com/dotnet/runtime/blob/4f9ae42d861fcb4be2fcd5d3d55d5f227d30e723/src/libraries/System.IO.Compression/src/System/IO/Compression/ZipArchive.cs#L655

On <= Win10 RS1, we do not use the XpsOM package to print. This means that XpsPrintJobStream is instantiated, which is not seekable. When the ZipArchive in the XPS package is disposed, it seeks its underlying stream to write it out. This causes a NotSupportedException, which fails printing.

There is an assumption in ZipArchive that streams opened for Update are seekable. We had used this to workaround a host of other issues in XPS document processing, but this seems to be incorrect here.

Fixing this DRT is going to require work to fix the entire printing and packaging infra to properly support the new S.IO.Compression/Packaging libraries.

@rladuca rladuca removed their assignment Apr 24, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue-type-test-bug Problem in test source code (most likely) rank40 Rank: Priority/rank on a scale of (1..100)
Projects
None yet
Development

No branches or pull requests

5 participants