Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for Default Items #1302

Closed
vatsan-madhavan opened this issue Jul 17, 2019 · 8 comments
Closed

Update documentation for Default Items #1302

vatsan-madhavan opened this issue Jul 17, 2019 · 8 comments
Labels
Documentation Documentation bug or enhancement, does not impact product or test code issue-type-tracking-external To track dependencies with other teams or repos

Comments

@vatsan-madhavan
Copy link
Member

vatsan-madhavan commented Jul 17, 2019 •
edited
Loading

#1264 (comment)

https://docs.microsoft.com/en-us/dotnet/core/tools/csproj#default-compilation-includes-in-net-core-projects needs to be updated.

https://aka.ms/sdkimplicititems should be updated with information about EnableDefaultPageItems and EnableDefaultApplicationDefinition

Also see #1300

/cc @grubioe
@ryalanms
Copy link
Member

These properties are used to determine if xaml files should automatically be added to Page and ApplicationDefinition items.

@grubioe grubioe added this to the 3.0 milestone Jul 18, 2019
@grubioe grubioe added the Documentation Documentation bug or enhancement, does not impact product or test code label Jul 18, 2019
@grubioe
Copy link
Contributor

grubioe commented Jul 23, 2019

@mairaw & @Thraka - is this something that you can help with (updating documentation)?

@Thraka
Copy link

Thraka commented Jul 23, 2019

Yes, can you file an issue in our repo?

Click here to create new issue linked to the article

Please be clear in the issue as to what needs to change. Just browsing through the linked issues, it seems that this is a problem introduced in Core 3.0 Preview X and will be fixed in Core 3.0 Preview 7?

@Thraka
Copy link

Thraka commented Jul 23, 2019

Also, do you document all of the MSBuild options WPF projects use? Gathering this information would up tell the story correctly in our repo.

@grubioe grubioe added the rank60 Rank: Priority/rank on a scale of (1..100) label Jul 24, 2019
@vatsan-madhavan
Copy link
Member Author

@grubioe, are these updates completed now?

@grubioe
Copy link
Contributor

grubioe commented Aug 17, 2019

Being addressed by Docs issue #13884

@vatsan-madhavan
Copy link
Member Author

Closing since it's being addressed

@vatsan-madhavan vatsan-madhavan mentioned this issue Sep 30, 2019
Closed
@grubioe
Copy link
Contributor

grubioe commented Oct 2, 2019

Issue to address this is #2642, ETA is November.

@grubioe grubioe added issue-type-tracking-external To track dependencies with other teams or repos and removed rank60 Rank: Priority/rank on a scale of (1..100) labels Oct 2, 2019
@grubioe grubioe assigned vatsan-madhavan and unassigned grubioe Nov 27, 2019
@vatsan-madhavan vatsan-madhavan removed their assignment Apr 7, 2020
@ghost ghost removed this from the 3.0 milestone Aug 22, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Documentation bug or enhancement, does not impact product or test code issue-type-tracking-external To track dependencies with other teams or repos
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Thraka @vatsan-madhavan @ryalanms @grubioe @pchaurasia14