Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 5 Intellisense data needs to be updated #3445

Closed
vatsan-madhavan opened this issue Sep 3, 2020 · 10 comments
Closed

.NET 5 Intellisense data needs to be updated #3445

vatsan-madhavan opened this issue Sep 3, 2020 · 10 comments
Milestone

Comments

@vatsan-madhavan
Copy link
Member

"dotnet-api-docs_netcoreapp3.0": "0.0.0.2",

.NET 5 still using intellisense data from .NET Core 3.0 docs. This needs to be updated to use .NET 5 docs based data.

@dotnet/dotnet-winforms - dotnet/winforms also has this bug I think.

winforms/global.json@L22 in 0416d4

    "dotnet-api-docs_netcoreapp3.0": "0.0.0.1"
@Tanya-Solyanik
Copy link
Member

@vatsan-madhavan - what is the value for 5.0?

@vatsan-madhavan
Copy link
Member Author

There isn't one yet. Once someone creates and uploads the zip bundles containing the right intellisense data to the Azure Blob Store, they can give it whatever version they want. I recommend the next value in the version space, like 0.0.0.2 ;-)

See https://github.com/dotnet/winforms/blob/master/docs/intellisense.md and https://github.com/dotnet/wpf/blob/master/Documentation/intellisense.md

@RussKie
Copy link
Member

RussKie commented Sep 4, 2020

@carlossanlop is this something you're working on?

@vatsan-madhavan
Copy link
Member Author

The blob items in WPF/Winforms repos were invented and owned by WPF. They are only meaningful in these repos because the targets that read them are custom-written for these repos. The zipped blob themselves are organized to match the expectations of these WPF/WinForms specific targets.

The content may come from docs repo build, but only a subset (specific to WPF/WinForms) of the intellisense XML's from docs-repo the build are xcopied over to created these zip/blobs.

In other words, these are not part of a generic Arcade facility, or owned by docs team etc.

I expect WPF would create the new blobs and upload them to the Azure Storage, and both repos would update their versions.

Ideally, this system should be deprecated/removed in favor of something more standardized provided by Arcade - when such a system becomes available.

@merriemcgaw
Copy link
Member

In that case making sure that @fabiant3 and @ryalanms have this on their radar. We definitely want to get something in for 5.0.

@AdamYoblick
Copy link
Member

What's the due date for this work please? 😄

@fabiant3
Copy link
Member

RC1 ships next week, so likely RC2?

@ryalanms ryalanms added this to the 5.0.0 milestone Sep 14, 2020
@TheFanatr
Copy link

Is there some news on this?

@RussKie RussKie removed their assignment Nov 10, 2020
@carlossanlop
Copy link
Member

@AdamYoblick can give more information, it's my understanding he was working on updating Intellisense for 5.0 in WPF and WinForms. We already updated IntelliSense in Runtime in RC2.

@AdamYoblick
Copy link
Member

AdamYoblick commented Nov 10, 2020

This has been absolutely done for a long time, the issue was just never updated.

Going to close out this issue.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants