Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPF source generator support should be on by default for .NET 6.0 #3974

Closed
ryalanms opened this issue Jan 10, 2021 · 3 comments
Closed

WPF source generator support should be on by default for .NET 6.0 #3974

ryalanms opened this issue Jan 10, 2021 · 3 comments
Assignees
@ryalanms
Labels
Document for new feature PR Proposed
Milestone
6.0.0

Comments

@ryalanms
Copy link
Member

Source generator support was added with #3846. This is an opt-in feature. To use it, users must set the property IncludePackageReferencesDuringMarkupCompilation to true.

Make source generator support on by default for .NET 6.0.
@ryalanms ryalanms self-assigned this Jan 11, 2021
@ryalanms ryalanms added this to the 6.0.0 milestone Jan 11, 2021
@ryalanms
Copy link
Member Author

The Arcade workaround for WPF must be removed from the Arcade SDK when this is turned on.

@Zalutskii Zalutskii mentioned this issue Jan 12, 2021
Closed
@clairernovotny
Copy link
Member

There's a related PR to track enabling it by default in the .NET SDK 5.0.200 here: It's also tracked here for the .NET SDK for 5.0.200: dotnet/sdk#15395

@clairernovotny clairernovotny mentioned this issue Jan 26, 2021
Merged
@ryalanms
Copy link
Member Author

ryalanms commented Feb 2, 2021

#4089

@ryalanms ryalanms closed this as completed Feb 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryalanms ryalanms

Labels
Document for new feature PR Proposed
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@clairernovotny @ryalanms