Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WPF's workaround for Arcade setting _WpfTempProjectNuGetFilePathNoExt #4119

Closed
ryalanms opened this issue Feb 2, 2021 · 1 comment · Fixed by #6071
Closed

Remove WPF's workaround for Arcade setting _WpfTempProjectNuGetFilePathNoExt #4119

ryalanms opened this issue Feb 2, 2021 · 1 comment · Fixed by #6071
Milestone

Comments

@ryalanms
Copy link
Member

ryalanms commented Feb 2, 2021

No description provided.

@ryalanms ryalanms changed the title Arcade workaround for WPF PackageReferences must be removed from the WPF and Arcade SDK Remove WPF's workaround for Arcade setting _WpfTempProjectNuGetFilePathNoExt Feb 2, 2021
@ryalanms ryalanms removed the Untriaged label Feb 4, 2021
@ryalanms ryalanms added this to the 6.0.0 milestone Feb 4, 2021
@tydunkel
Copy link

tydunkel commented Jul 8, 2021

Just discovered that this was causing issues in our build. Adding this to the GlobalProperties resulted in out WPF projects rebuilding dependent assemblies, copying the original output from obj to bin. After copying to bin our build signs the assembly, so at that point an unsigned assembly replaced a signed assembly.

We build projects in parallel, so some projects depending on the original project are building but will be taking an unsigned version of the assembly until the newly copied assembly is signed. This resulted in build failures since some assemblies are unsigned in our nupkgs.

To fix this, we just added _WpfTempProjectNuGetFilePathNoExt to GlobalPropertiesToRemove when we build WPF projects. Easy workaround, but took awhile to figure out which property was causing the rebuild.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants