Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests solution doesn't build in VisualStudio #599

Closed
rookie0jnr opened this issue Apr 17, 2019 · 3 comments
Closed

Tests solution doesn't build in VisualStudio #599

rookie0jnr opened this issue Apr 17, 2019 · 3 comments
Assignees
Labels
Bug Product bug (most likely)
Milestone

Comments

@rookie0jnr
Copy link

.NET Core Version: (e.g. 3.0 Preview1, or daily build number, use dotnet --info)
.NET Core SDK (reflecting any global.json):
Version: 3.0.100-preview5-011322
Commit: 3d3dd1648a

Runtime Environment:
OS Name: Windows
OS Version: 10.0.17134
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\3.0.100-preview5-011322\

Host (useful for support):
Version: 3.0.0-preview5-27616-01
Commit: e32693473d

.NET Core SDKs installed:
2.1.700-preview-009597 [C:\Program Files\dotnet\sdk]
2.2.300-preview-010046 [C:\Program Files\dotnet\sdk]
3.0.100-preview5-011322 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.0.0-preview5-19215-07 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.0.0-preview5-27616-01 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.0.0-preview5-27616-01 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Windows version: (winver)
Version 1803 (OS Build 17134.706)

Does the bug reproduce also in WPF for .NET Framework 4.8?: Yes/No
I don't think that this happens in WPF for .NET Framework 4.8.

Problem description:
I cloned this repository, performed build.cmd and open the Tests.sln in VisualStudio 2019 preview. And the solution does not build. It seems that the problem is in the BamlAvoidXmlTest project and in the references that it has.It seems that NuGet cannot find/resolve these dependencies. Please check the attached screen-shot.
Please note also, that the tests can be executed from the command line. But my main goal is to examine/execute/debug these tests from VisualStudio.
Am I missing something? Are there some additional steps/conditions needed in order to build/execute this tests within TestStudio?

NuGet errors

@ryalanms
Copy link
Member

+@ojhad, @miguep.

@ryalanms ryalanms added the Bug Product bug (most likely) label Apr 17, 2019
@vatsan-madhavan
Copy link
Member

To solve this right, I think we need to adopt (for tests) RuntimeTargetFramework + TargetingPackVersion + an update to tools.dotnet/sdk.version in global.json, likely all predicated on dotnet/arcade#2343 becoming available.

Then likely we'll have to merge the test-projects into the main solution (i.e., not maintain two separate solutions) and using Microsoft.NET.SDK exclusively for builds (instead of using Micoroft.NET.Sdk.WindowsDesktop, which is an odd self-referential way of building tests).

I have a prototype in the works that I created as part of #604 (and the original RuntimeTargetFramework PR) that I was working on last week.

A short term workaround might look like this, although I wouldn't recommend that we fix it this way (esp. since dotnet/arcade#2343 will likely become available next week-ish).

<KnowFrameworkReference Remove="Microsoft.ApsNetCore.App" Condition='''$(WpfTest)'=='true'" />

@grubioe grubioe added this to the Preview milestone Apr 19, 2019
@rladuca
Copy link
Member

rladuca commented May 20, 2019

This should be fixed now, resolving.

@rladuca rladuca closed this as completed May 20, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Product bug (most likely)
Projects
None yet
Development

No branches or pull requests

7 participants