Dynamically Create TextBox Issue

[turboyang-cn]

• .NET Core Version: 3.0.100-preview6-012264
• OS: Windows 10
• OS Version: 17134.471
• Visual Studio Version: Visual Studio 2019 16.1.3

Errors occurred when I created text boxes dynamically in my code

System.ArgumentException:"Requested value 'Delete' was not found."

TextBox TextBox = new TextBox();

[lindexi]

Can you give a minimal repository? I run your code in my project and I can not find the exception.

My version is 3.0.100-preview5-011568

[turboyang-cn]

https://github.com/turboyang-cn/wpf-core-test

There's no problem with this version. The problem is in the new version (3.0.100-preview6-012264).

[turboyang-cn]

[lindexi]

It seems a language issues.

The code will call CommandHelpers.RegisterCommandHandler the register command

wpf/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Documents/TextEditorTyping.cs

Line 81 in 9afa976

CommandHelpers.RegisterCommandHandler(controlType, EditingCommands.Delete , new ExecutedRoutedEventHandler(OnDelete) , onQueryStatusNYI , KeyDelete, SRID.KeyDeleteDisplayString );

In this code, the MS.Internal.Commands.CommandHelpers.RegisterCommandHandler will use SR.Get(srid1) to change the argument srid1 to language value. The SR.Get(srid1) will change the value of srid1 from KeyDelete to the Chinese word 删除 but the expected word is delete

wpf/src/Microsoft.DotNet.Wpf/src/PresentationFramework/MS/Internal/Commands/CommandHelpers.cs

Lines 83 to 88 in ae17905

	internal static void RegisterCommandHandler(Type controlType, RoutedCommand command, ExecutedRoutedEventHandler executedRoutedEventHandler,
	string srid1, string srid2)
	{
	PrivateRegisterCommandHandler(controlType, command, executedRoutedEventHandler, null,
	KeyGesture.CreateFromResourceStrings(SR.Get(srid1), SR.Get(srid2)));
	}

The KeyGesture.CreateFromResourceStrings need the arguments with keyGestureToken and the value of keyGestureToken is a Chinese word 删除, not the expected word delete.

And the code will use the Chinese word to ConvertFromInvariantString which will call the PresentationCore.dll!System.Windows.Input.KeyGestureConverter.ConvertFrom(System.ComponentModel.ITypeDescriptorContext context, System.Globalization.CultureInfo culture, object source)

wpf/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/Command/KeyGesture.cs

Line 299 in ae17905

return _keyGestureConverter.ConvertFromInvariantString(keyGestureToken) as KeyGesture;

I find the value of source in KeyGestureConverter.ConvertFrom is the Chinese word.

wpf/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/Command/KeyGestureConverter.cs

Line 82 in ae17905

public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object source)

And the KeyGestureConverter.ConvertFrom will call Enum.Parse that will throw exception.

And the ConvertFrom will call the keyConverter.ConvertFrom to convert the keyToken and the keyToken is the Chinese word.

wpf/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/Command/KeyGestureConverter.cs

Line 120 in ae17905

object resultkey = keyConverter.ConvertFrom(context, culture, keyToken);

And the KeyConverter will call the KeyConverter.GetKey which the value of fullName is the Chinese word.

wpf/src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/Input/KeyConverter.cs

Line 90 in ae17905

object key = GetKey(fullName, CultureInfo.InvariantCulture);

And the KeyConverter.GetKey can not find the keyToken which is the Chinese word and call the Enum to Parse the Key and throw exception.

The Key enum can not find any key name as the Chinese word 删除

wpf/src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/Input/KeyConverter.cs

Line 220 in ae17905

default: keyFound = (Key)Enum.Parse(typeof(Key), keyToken, true); break;

[lindexi]

This issus can be closed, because @ryalanms fix it in #919

[lindexi]

Thank for @ryalanms. And he change SRID.KeyDelete which value is "KeyDelete" to KeyDelete which value is "Delete" that can fix it.

- CommandHelpers.RegisterCommandHandler(controlType, EditingCommands.Delete               , new ExecutedRoutedEventHandler(OnDelete)               , onQueryStatusNYI                  , SRID.KeyDelete,           SRID.KeyDeleteDisplayString                 );
+ CommandHelpers.RegisterCommandHandler(controlType, EditingCommands.Delete               , new ExecutedRoutedEventHandler(OnDelete)               , onQueryStatusNYI                  , KeyDelete,           SRID.KeyDeleteDisplayString                 );

9afa976#diff-8491c698fe3be6a213b6db468e74c815L81

Because ResourceManager.GetString("Delete") will return null and ResourceManager.GetString("KeyDelete") will return the Chinese word "删除" and the SR.GetResourceString will return the resourceKey when not found.

And the Key enum can find the "Delete" value.