Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload certificate at run time #93

Closed
tomstreet opened this issue Apr 24, 2020 · 6 comments
Closed

Reload certificate at run time #93

tomstreet opened this issue Apr 24, 2020 · 6 comments
Labels
Type: Idea This issue is a high-level idea for discussion.

Comments

@tomstreet
Copy link

What should we add or change to make your life better?

It would be nice to ultimately have support for letsencrypt. Not sure that it makes sense to add letsencrypt support specifically, but at least some way of automatically reloading a cert when it changes?

Why is this important to you?

We currently use nginx and cert-manager in kubernetes, but would love to get rid of nginx and just use kestrel on the edge (using this project!) but we need a way to either automatically update the cert in kestrel when cert-manager grabs a new one, or even better, get rid of cert-manager and have the edge proxy manage its own certs with built in letsencrypt integration.

@tomstreet tomstreet added the Type: Idea This issue is a high-level idea for discussion. label Apr 24, 2020
@Tratcher
Copy link
Member

@tomstreet
Copy link
Author

Yeh - we currently plan to use that along with https://github.com/ProxyKit/ProxyKit. Just thought I'd suggest it as a core feature here.

@analogrelay
Copy link
Contributor

I do think having Let's Encrypt as a core feature is valid (though perhaps not in v1). We have #110 tracking that already.

@Tratcher @halter73 is the rest of this (updating the certificate, separate from Let's Encrypt) possible already with the SNI callback? I realize it's not async, but you could (today) still have a background process reloading it and swap it out, right?

@Tratcher
Copy link
Member

Yes, the SNI callback allows you to use a new cert every time a connection starts. That's how the LetsEncrypt integration works. It's a bit manual if you want to do it yourself though. We're tracking a few related improvements:

@analogrelay
Copy link
Contributor

My sense then is to close this out. We have #110 tracking native support for LE. We have the issues you listed above (which we can add to our tracking board) for improvements to SNI.

@analogrelay
Copy link
Contributor

Triage: Let's close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Idea This issue is a high-level idea for discussion.
Projects
None yet
Development

No branches or pull requests

3 participants