ref(ios, events): improve disabling of playback-progress-updated

[puckey]

• When 0 is passed to options["progressUpdateEventInterval”] in order to disable ‘playback-progress-updated’ event, set timeEventFrequency back to the default of every second.
• rename (private) shouldEmitUpdateEventInterval to shouldEmitProgressEvent

[jspizziri]

@puckey was this already the default behavior on the Kotlin side?

[puckey]

@puckey was this already the default behavior on the Kotlin side?

Good point – I haven't checked that yet. Let's keep this open until I have done so.

[puckey]

@jspizziri I am unable to find the same issue on the kotlin side that ios has where you are unable to 'cancel' this interval  (see your comments here:

react-native-track-player/ios/RNTrackPlayer/RNTrackPlayer.swift

Lines 817 to 821 in a243210

	// because you cannot prevent the `event.secondElapse` from firing
	// do not emit an event if `progressUpdateEventInterval` is nil
	// additionally, there are certain instances in which this event is emitted
	// _after_ a manipulation to the queu causing no currentItem to exist (see reset)
	// in which case we shouldn't emit anything or we'll get an exception.

)

Here is the kotlin side which looks like it cancels the job and then doesn't recreate it when set to 0:

react-native-track-player/android/src/main/java/com/doublesymmetry/trackplayer/service/MusicService.kt

Lines 152 to 159 in e94e436

	// setup progress update events if configured
	progressUpdateJob?.cancel()
	val updateInterval = Utils.getIntOrNull(options, PROGRESS_UPDATE_EVENT_INTERVAL_KEY)
	if (updateInterval != null && updateInterval > 0) {
	progressUpdateJob = scope.launch {
	progressUpdateEventFlow(updateInterval.toLong()).collect { emit(MusicEvents.PLAYBACK_PROGRESS_UPDATED, it) }
	}
	}

[jspizziri]

The big difference I see here is that we're setting the interval to 1s when we cancel, which we weren't doing before. Are we sure this is desired?

[puckey]

the reason I am doing this is that the user might have set the interval to something very small temporarily, expecting that setting it back to 0 would return stuff to normal.. (I was going off the comment that says it is impossible to turn it off..)

[puckey]

See the default value here in SwiftAudioEx: https://github.com/doublesymmetry/SwiftAudioEx/blob/main/SwiftAudioEx/Classes/AVPlayerWrapper/AVPlayerWrapper.swift#L136

[jspizziri]

Left a question, but lgtm apart from that.

[jspizziri]

LGTM!