Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #537
What problem does this code solve?
Corrects bug in
XML.unescape
where it was incorrectly passing entities to be unescaped without lower-casing first as the tokener does internally. This corrects the issue at the tokener level by not requiring the entity to be lowercase before processing.Risks
None. Bug fix
Changes to the API?
No
Will this require a new release?
Yes
Should the documentation be updated?
No need
Does it break the unit tests?
No. New unit tests have been added showing the tokener properly parsing, but the direct call failing, then succeeding after the code change
Was any code refactored in this commit?
Just some test calls to make error reporting easier to read:
changed some calls that looked like this:
to
Review status
APPROVED