Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite only if data exists in the row #33

Open
shyim opened this issue Feb 10, 2022 · 3 comments
Open

Rewrite only if data exists in the row #33

shyim opened this issue Feb 10, 2022 · 3 comments
Assignees
Labels
feature signals requested features

Comments

@shyim
Copy link
Contributor

shyim commented Feb 10, 2022

Currently, the rewrite feature replaces all rows with the value. I guess that hurts the reproducibility of bugs as the data is not the same.

My idea would be to change the SELECT to IF(colum IS NULL, NULL, REPLACEMNET) as X. With a new option.

What do you think about that? I could provide a PR

@bolovsky
Copy link
Member

That actually should pretty good as a feature to ensure issues are correctly reproducible.

you can also use COALESCE (same same, just syntactic sugar) as COALESCE(column, REPLACEMENT) ;)

@shyim
Copy link
Contributor Author

shyim commented Feb 10, 2022

Do we want it on table/column level or just global as option 🤔

@bolovsky
Copy link
Member

I would say global as option would probably be more consistent. Also, having it per table could rapidly become a configuration issue :)

@bolovsky bolovsky added the feature signals requested features label Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature signals requested features
Projects
None yet
Development

No branches or pull requests

2 participants