Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search input is not cleared on selection #409

Closed
berdyshev opened this issue Aug 6, 2020 · 2 comments · Fixed by #410
Closed

Search input is not cleared on selection #409

berdyshev opened this issue Aug 6, 2020 · 2 comments · Fixed by #410

Comments

@berdyshev
Copy link
Contributor

berdyshev commented Aug 6, 2020

When using both clearSearchOnChange and inlineSearchInput options, the search input it not cleared inside the opened dropdown upon selecting one of the search results. This is a weird UX — I think the input should be cleared on selection too.

I found this piece of code which is not clear for me..

https://www.loom.com/share/ae3bef73fd7345b78468dd853955973c

@mrchief
Copy link
Collaborator

mrchief commented Aug 6, 2020

@berdyshev Thanks for the details! I agree about the UX expectation here. The line you pointed is a defensive check - inline search is part of the dropdown div, so unless the dropdown is visible, that ref will be null.

Would you like to send a PR?

@github-actions
Copy link

github-actions bot commented Aug 9, 2020

🎉 This issue has been resolved in version 2.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants