Skip to content

Conversation

@m4theushw
Copy link
Contributor

What does it do?

Adds a tagLabel prop for those use cases where you want to display something different in a tag label compared to the checkbox one. I reused the work done in #317.

Fixes # (issue)

Fixes #316

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Updated documentation (if applicable)
  • Added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit d360047 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1473

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 94.005%

Totals Coverage Status
Change from base Build 1460: 0.01%
Covered Lines: 601
Relevant Lines: 622

💛 - Coveralls

@mrchief
Copy link
Collaborator

mrchief commented Aug 7, 2020

Thanks for sending this @m4theushw!

@all-contributors please add @m4theushw for code

@allcontributors
Copy link
Contributor

@mrchief

I've put up a pull request to add @m4theushw! 🎉

@mrchief mrchief merged commit 25ff055 into dowjones:develop Aug 9, 2020
@github-actions
Copy link

github-actions bot commented Aug 9, 2020

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

m4theushw added a commit to m4theushw/react-dropdown-tree-select that referenced this pull request Sep 20, 2020
)

Co-authored-by: Bulletninja <luis.linuxero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different label in tree vs Tag

4 participants